Increase oracle client timeout from 5 to 60 minutes. #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout is so high to prevent a rare race condition from happening. We need clients to wait till chief oracle server starts. This normally takes a few minutes, but sometimes might take longer. See keras-team#990 for more details. Initially we didn't have any timeout. It was introduced to avoid tuner jobs hanging forever if chief oracle stops responding. See keras-team#957.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 98.37% 97.50% -0.88%
==========================================
Files 50 50
Lines 3085 3085
==========================================
- Hits 3035 3008 -27
- Misses 50 77 +27 ☔ View full report in Codecov by Sentry. |
|
A few more changes needed. I will take over. |
Merged
haifeng-jin
pushed a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout is so high to prevent a rare race condition from happening. We need clients to wait till chief oracle server starts. This normally takes a few minutes, but sometimes might take longer.
See #990 for more details. Initially we didn't have any timeout. It was introduced to avoid tuner jobs hanging forever if chief oracle stops responding.
See #957.