Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oracle_client.py to enable_http_proxy #981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbk0
Copy link

@pbk0 pbk0 commented Nov 25, 2023

Line 35 anyway makes an insecure channel and expects that users are on a safe network. But it still uses https urls and some corporate environments try to verify certificates (as in my case) and it breaks. So adding the second line instead of the first worked in my case and ends up using http links.

# original
channel = grpc.insecure_channel(f"{ip_addr}:{port}")
# update to this
channel = grpc.insecure_channel(f"{ip_addr}:{port}", options=(('grpc.enable_http_proxy', 0),))

Line 35 anyway makes an insecure channel and expects that users are on a safe network. But it still uses https proxies and some corporate environments try to block it (as in my case). So adding the second line instead of the first worked in my case.
``` python
channel = grpc.insecure_channel(f"{ip_addr}:{port}")
channel = grpc.insecure_channel(f"{ip_addr}:{port}", options=(('grpc.enable_http_proxy', 0),))
```
Copy link

google-cla bot commented Nov 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92d713a) 98.37% compared to head (895503f) 98.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          50       50           
  Lines        3085     3085           
=======================================
  Hits         3035     3035           
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant