Misc fixes to docstrings #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/gcbrun |
mattdangerw
commented
Apr 19, 2023
jbischof
approved these changes
Apr 19, 2023
Contributor
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
Thank you!
Ideally we would have an automated way to run our extra_large and docstring tests every day/week on GCP without having to worry about this on every PR.
Member
Author
Fully agreed. A nightly testing routine would be a big help. |
Another round of style edits, and breakage fixes for docstrings. With these changes, all our fenced docstrings now run across the repo! Though it does take 20 minutes on a fairly large machine.
mattdangerw
force-pushed
the
misc-docstring-fixes
branch
from
b19b8bd to
6548c51
Compare
Member
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of style edits, and breakage fixes for docstrings.
With these changes, all our fenced docstrings now run across the repo! Though it does take 20 minutes on a fairly large machine.
Fixes #867
Fixes #641