Skip to content

Add start/end token padding to GPT2Preprocessor #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenmoneygithub merged 2 commits into from
Feb 1, 2023
Merged

Add start/end token padding to GPT2Preprocessor #704

chenmoneygithub merged 2 commits into from
Feb 1, 2023

Conversation

@chenmoneygithub
Copy link
Contributor

@chenmoneygithub chenmoneygithub commented Jan 30, 2023

Resolve #702

mattdangerw
mattdangerw reviewed Jan 31, 2023
View reviewed changes
@mattdangerw mattdangerw mentioned this pull request Feb 1, 2023
Merged
mattdangerw
mattdangerw approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chen! LGTM

@chenmoneygithub chenmoneygithub merged commit aeef706 into keras-team:master Feb 1, 2023
@chenmoneygithub chenmoneygithub deleted the fix-gpt2 branch February 2, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support adding start_token and end_token in GPT2Preprocessor

2 participants

@chenmoneygithub @mattdangerw