Skip to content

Ignore Task Docstring for Testing #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdangerw merged 1 commit into from
Jan 19, 2023
Merged

Ignore Task Docstring for Testing #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion keras_nlp/tests/doc_tests/docstring_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ def test_fenced_docstrings():
# Base classes.
"keras_nlp.models.backbone",
"keras_nlp.models.preprocessor",
# Preprocessors and tokenizers which use `model.spm`.
"keras_nlp.models.task",
Copy link
Member

@mattdangerw mattdangerw Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I bet we can just extend the regex "skip" line in the fenced lib to not test our unformatted docstring containing {{ and }}. I can add that after this lands.

# Preprocessors and tokenizers which use `model.spm` (temporary).
"keras_nlp.models.albert.albert_preprocessor",
"keras_nlp.models.albert.albert_tokenizer",
"keras_nlp.models.xlm_roberta.xlm_roberta_preprocessor",
Expand Down