GPT2 Text Generation APIs #592
Conversation
chenmoneygithub
force-pushed
the
text-generation-playground
branch
4 times, most recently
from
8cd580c to
e3a82a6
Compare
chenmoneygithub
force-pushed
the
text-generation-playground
branch
from
e3a82a6 to
0eb68f6
Compare
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
Looks very clean, thanks for sharing! I would love to understand the CasualLMPreprocessor better.
The samplers/ code should be moved to a different PR.
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Not a full review, but left some quick comments!
chenmoneygithub
force-pushed
the
text-generation-playground
branch
from
18fe549 to
8206103
Compare
chenmoneygithub
force-pushed
the
text-generation-playground
branch
from
4d9a9b7 to
4fa8fc5
Compare
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Left some initial comments!
chenmoneygithub
force-pushed
the
text-generation-playground
branch
from
ac24a04 to
cb12604
Compare
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
A lot of progress here! Left some comments.
Can you add a link to the demo colab? Would love to play around with this a bit.
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
LGTM! Let's consider a out of box option to prepend an "end of text" token to input sequences. I believe this is standard practice, but we can check.
Since this is a big one, probably good to wait for an ack from @jbischof too!
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
The colab needs some updating but the PR is great. Thank you!
3 participants
You can view the demo via this link