Disable DINO quantisation checks #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables quantization checks for the DINOV2 backbone tests. While the change is straightforward, the pull request lacks a description and the code changes do not include comments explaining why this is necessary. Disabling tests without an explanation can create technical debt and make future maintenance more difficult. I have added suggestions to include comments in the code to document the reason for this change.
JyotinderSingh
approved these changes
Sep 12, 2025
Collaborator
JyotinderSingh
left a comment
JyotinderSingh
left a comment
There was a problem hiding this comment.
Thanks for the temporary fix!
Collaborator
|
Merging it, to cherry-pick and run the tests in release branch. |
sachinprasadhs
approved these changes
Sep 12, 2025
sachinprasadhs
pushed a commit
to sachinprasadhs/keras-hub
that referenced
this pull request
Sep 12, 2025
sachinprasadhs
added a commit
that referenced
this pull request
Sep 12, 2025
* Fixes (#2395) * Adding fixes * Adding fixes * Adding Fixes * patch release * Disable DINO quantisation checks (#2397) --------- Co-authored-by: Suhana <[email protected]> Co-authored-by: Abheesht <[email protected]>
6 tasks
amitsrivastava78
pushed a commit
to amitsrivastava78/keras-hub
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disabling DINO quantisation checks to unblock VaultGemma release