Fix the issue of propagating training argument in subclasses
#1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly ping @mattdangerw This issue needs to be fixed for the float8 example on keras.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue while trying to create a float8 training/inference example for keras.io.
In Keras3 (I haven't verified this in Keras2),
trainingargument isn't propagated when using subclasses likekeras_nlp.layers.TransformerDecoder, unless we explicitly exposetraining=Nonein the signature ofcall.I've added the tests to confirm that this issue has been resolved and they can only pass with this PR.