-
Notifications
You must be signed in to change notification settings - Fork 310
Add presets for Electra and checkpoint conversion script #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f812c39
Added ElectraBackbone
pranavvp16 879020a
Merge branch 'keras-team:master' into electra
pranavvp16 c2aa9bd
Added backbone tests for ELECTRA
pranavvp16 79df89f
Fix config
pranavvp16 7bc3697
Add model import to __init__
pranavvp16 b7bcfcf
add electra tokenizer
pranavvp16 8d9dd15
add tests for tokenizer
pranavvp16 273075a
add __init__ file
pranavvp16 bfbf648
add tokenizer and backbone to models __init__
pranavvp16 a79deb1
Merge branch 'master' into electra
pranavvp16 538d938
Fix Failing tokenization test
pranavvp16 eb8baa5
Merge remote-tracking branch 'origin/electra' into electra
pranavvp16 b3f81d5
Merge branch 'keras-team:master' into electra
pranavvp16 47c9119
Add example on usage of the tokenizer with custom vocabulary
pranavvp16 ec9f683
Merge branch 'keras-team:master' into electra
pranavvp16 e3bad73
Add conversion script to convert weights from checkpoint
pranavvp16 148913d
Add electra preprocessor
pranavvp16 06dfae9
Add presets and tests
pranavvp16 3b72d15
Add presets config with model weights
pranavvp16 fcdcbbb
Add checkpoint conversion script
pranavvp16 d025883
Name conversion for electra models
pranavvp16 97b94ee
Update naming conventions according to preset names
pranavvp16 316a15a
Merge branch 'master' into electra
pranavvp16 b52d8b5
Fix failing tokenizer tests
pranavvp16 2e038eb
Merge branch 'keras-team:master' into electra
pranavvp16 e256609
Update checkpoint conversion script according to kaggle
pranavvp16 33e9fb1
Add validate function
pranavvp16 5775fad
Merge branch 'keras-team:master' into electra
pranavvp16 2b70228
Kaggle preset
pranavvp16 b9d93e0
update preset link
pranavvp16 f53b9db
Add electra presets
pranavvp16 4be8d50
Merge branch 'keras-team:master' into electra
pranavvp16 b268e26
Complete run_small_preset test for electra
pranavvp16 0411151
Add large variations of electra in presets
pranavvp16 fa9a2f2
Merge remote-tracking branch 'origin/master' into electra
pranavvp16 0bb7b64
Fix case issues with electra presets
mattdangerw c49e4ac
Fix format
mattdangerw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| # Copyright 2023 The KerasNLP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import copy | ||
|
|
||
| from keras_nlp.api_export import keras_nlp_export | ||
| from keras_nlp.layers.preprocessing.multi_segment_packer import ( | ||
| MultiSegmentPacker, | ||
| ) | ||
| from keras_nlp.models.electra.electra_presets import backbone_presets | ||
| from keras_nlp.models.electra.electra_tokenizer import ElectraTokenizer | ||
| from keras_nlp.models.preprocessor import Preprocessor | ||
| from keras_nlp.utils.keras_utils import ( | ||
| convert_inputs_to_list_of_tensor_segments, | ||
| ) | ||
| from keras_nlp.utils.keras_utils import pack_x_y_sample_weight | ||
| from keras_nlp.utils.python_utils import classproperty | ||
|
|
||
|
|
||
| @keras_nlp_export("keras_nlp.models.ElectraPreprocessor") | ||
| class ElectraPreprocessor(Preprocessor): | ||
| """A ELECTRA preprocessing layer which tokenizes and packs inputs. | ||
|
|
||
| This preprocessing layer will do three things: | ||
|
|
||
| 1. Tokenize any number of input segments using the `tokenizer`. | ||
| 2. Pack the inputs together using a `keras_nlp.layers.MultiSegmentPacker`. | ||
| with the appropriate `"[CLS]"`, `"[SEP]"` and `"[PAD]"` tokens. | ||
| 3. Construct a dictionary of with keys `"token_ids"` and `"padding_mask"`, | ||
| that can be passed directly to a ELECTRA model. | ||
|
|
||
| This layer can be used directly with `tf.data.Dataset.map` to preprocess | ||
| string data in the `(x, y, sample_weight)` format used by | ||
| `keras.Model.fit`. | ||
|
|
||
| Args: | ||
| tokenizer: A `keras_nlp.models.ElectraTokenizer` instance. | ||
| sequence_length: The length of the packed inputs. | ||
| truncate: string. The algorithm to truncate a list of batched segments | ||
| to fit within `sequence_length`. The value can be either | ||
| `round_robin` or `waterfall`: | ||
| - `"round_robin"`: Available space is assigned one token at a | ||
| time in a round-robin fashion to the inputs that still need | ||
| some, until the limit is reached. | ||
| - `"waterfall"`: The allocation of the budget is done using a | ||
| "waterfall" algorithm that allocates quota in a | ||
| left-to-right manner and fills up the buckets until we run | ||
| out of budget. It supports an arbitrary number of segments. | ||
|
|
||
| Call arguments: | ||
| x: A tensor of single string sequences, or a tuple of multiple | ||
| tensor sequences to be packed together. Inputs may be batched or | ||
| unbatched. For single sequences, raw python inputs will be converted | ||
| to tensors. For multiple sequences, pass tensors directly. | ||
| y: Any label data. Will be passed through unaltered. | ||
| sample_weight: Any label weight data. Will be passed through unaltered. | ||
|
|
||
| Examples: | ||
|
|
||
| Directly calling the layer on data. | ||
| ```python | ||
| preprocessor = keras_nlp.models.ElectraPreprocessor.from_preset( | ||
| "electra_base_discriminator_en" | ||
| ) | ||
| preprocessor(["The quick brown fox jumped.", "Call me Ishmael."]) | ||
|
|
||
| # Custom vocabulary. | ||
| vocab = ["[UNK]", "[CLS]", "[SEP]", "[PAD]", "[MASK]"] | ||
| vocab += ["The", "quick", "brown", "fox", "jumped", "."] | ||
| tokenizer = keras_nlp.models.ElectraTokenizer(vocabulary=vocab) | ||
| preprocessor = keras_nlp.models.ElectraPreprocessor(tokenizer) | ||
| preprocessor("The quick brown fox jumped.") | ||
| ``` | ||
|
|
||
| Mapping with `tf.data.Dataset`. | ||
| ```python | ||
| preprocessor = keras_nlp.models.ElectraPreprocessor.from_preset( | ||
| "electra_base_discriminator_en" | ||
| ) | ||
|
|
||
| first = tf.constant(["The quick brown fox jumped.", "Call me Ishmael."]) | ||
| second = tf.constant(["The fox tripped.", "Oh look, a whale."]) | ||
| label = tf.constant([1, 1]) | ||
| # Map labeled single sentences. | ||
| ds = tf.data.Dataset.from_tensor_slices((first, label)) | ||
| ds = ds.map(preprocessor, num_parallel_calls=tf.data.AUTOTUNE) | ||
|
|
||
|
|
||
| # Map unlabeled single sentences. | ||
| ds = tf.data.Dataset.from_tensor_slices(first) | ||
| ds = ds.map(preprocessor, num_parallel_calls=tf.data.AUTOTUNE) | ||
|
|
||
| # Map labeled sentence pairs. | ||
| ds = tf.data.Dataset.from_tensor_slices(((first, second), label)) | ||
| ds = ds.map(preprocessor, num_parallel_calls=tf.data.AUTOTUNE) | ||
| # Map unlabeled sentence pairs. | ||
| ds = tf.data.Dataset.from_tensor_slices((first, second)) | ||
|
|
||
| # Watch out for tf.data's default unpacking of tuples here! | ||
| # Best to invoke the `preprocessor` directly in this case. | ||
| ds = ds.map( | ||
| lambda first, second: preprocessor(x=(first, second)), | ||
| num_parallel_calls=tf.data.AUTOTUNE, | ||
| ) | ||
| ``` | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| tokenizer, | ||
| sequence_length=512, | ||
| truncate="round_robin", | ||
| **kwargs, | ||
| ): | ||
| super().__init__(**kwargs) | ||
| self.tokenizer = tokenizer | ||
| self.packer = MultiSegmentPacker( | ||
| start_value=self.tokenizer.cls_token_id, | ||
| end_value=self.tokenizer.sep_token_id, | ||
| pad_value=self.tokenizer.pad_token_id, | ||
| truncate=truncate, | ||
| sequence_length=sequence_length, | ||
| ) | ||
|
|
||
| def get_config(self): | ||
| config = super().get_config() | ||
| config.update( | ||
| { | ||
| "sequence_length": self.packer.sequence_length, | ||
| "truncate": self.packer.truncate, | ||
| } | ||
| ) | ||
| return config | ||
|
|
||
| def call(self, x, y=None, sample_weight=None): | ||
| x = convert_inputs_to_list_of_tensor_segments(x) | ||
| x = [self.tokenizer(segment) for segment in x] | ||
| token_ids, segment_ids = self.packer(x) | ||
| x = { | ||
| "token_ids": token_ids, | ||
| "segment_ids": segment_ids, | ||
| "padding_mask": token_ids != self.tokenizer.pad_token_id, | ||
| } | ||
| return pack_x_y_sample_weight(x, y, sample_weight) | ||
|
|
||
| @classproperty | ||
| def tokenizer_cls(cls): | ||
| return ElectraTokenizer | ||
|
|
||
| @classproperty | ||
| def presets(cls): | ||
| return copy.deepcopy({**backbone_presets}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # Copyright 2023 The KerasNLP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import pytest | ||
|
|
||
| from keras_nlp.models.electra.electra_preprocessor import ElectraPreprocessor | ||
| from keras_nlp.models.electra.electra_tokenizer import ElectraTokenizer | ||
| from keras_nlp.tests.test_case import TestCase | ||
|
|
||
|
|
||
| class ElectraPreprocessorTest(TestCase): | ||
| def setUp(self): | ||
| self.vocab = ["[PAD]", "[UNK]", "[CLS]", "[SEP]", "[MASK]"] | ||
| self.vocab += ["THE", "QUICK", "BROWN", "FOX"] | ||
| self.vocab += ["the", "quick", "brown", "fox"] | ||
| self.tokenizer = ElectraTokenizer(vocabulary=self.vocab) | ||
| self.init_kwargs = { | ||
| "tokenizer": self.tokenizer, | ||
| "sequence_length": 8, | ||
| } | ||
| self.input_data = ( | ||
| ["THE QUICK BROWN FOX."], | ||
| [1], # Pass through labels. | ||
| [1.0], # Pass through sample_weights. | ||
| ) | ||
|
|
||
| def test_preprocessor_basics(self): | ||
| self.run_preprocessing_layer_test( | ||
| cls=ElectraPreprocessor, | ||
| init_kwargs=self.init_kwargs, | ||
| input_data=self.input_data, | ||
| expected_output=( | ||
| { | ||
| "token_ids": [[2, 5, 6, 7, 8, 1, 3, 0]], | ||
| "segment_ids": [[0, 0, 0, 0, 0, 0, 0, 0]], | ||
| "padding_mask": [[1, 1, 1, 1, 1, 1, 1, 0]], | ||
| }, | ||
| [1], # Pass through labels. | ||
| [1.0], # Pass through sample_weights. | ||
| ), | ||
| ) | ||
|
|
||
| def test_errors_for_2d_list_input(self): | ||
| preprocessor = ElectraPreprocessor(**self.init_kwargs) | ||
| ambiguous_input = [["one", "two"], ["three", "four"]] | ||
| with self.assertRaises(ValueError): | ||
| preprocessor(ambiguous_input) | ||
|
|
||
| @pytest.mark.extra_large | ||
| def test_all_presets(self): | ||
| for preset in ElectraPreprocessor.presets: | ||
| self.run_preset_test( | ||
| cls=ElectraPreprocessor, | ||
| preset=preset, | ||
| input_data=self.input_data, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Copyright 2023 The KerasNLP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """ELECTRA model preset configurations.""" | ||
|
|
||
| backbone_presets = { | ||
| "electra_base_discriminator_en": { | ||
| "metadata": { | ||
| "description": ( | ||
| "ELECTRA: Pre-training Text Encoders as Discriminators Rather Than Generators" | ||
| "This is base discriminator model with 12 layers." | ||
| ), | ||
| "params": 109482240, | ||
| "official_name": "ELECTRA", | ||
| "path": "electra", | ||
| "model_card": "https://github.com/google-research/electra", | ||
| }, | ||
| "kaggle_handle": "kaggle://pranavprajapati16/electra/keras/electra_base_discriminator_en/1", | ||
| }, | ||
| "electra_small_discriminator_en": { | ||
| "metadata": { | ||
| "description": ( | ||
| "ELECTRA: Pre-training Text Encoders as Discriminators Rather Than Generators" | ||
| "This is small discriminator model with 12 layers." | ||
| ), | ||
| "params": 13548800, | ||
| "official_name": "ELECTRA", | ||
| "path": "electra", | ||
| "model_card": "https://github.com/google-research/electra", | ||
| }, | ||
| "kaggle_handle": "kaggle://pranavprajapati16/electra/keras/electra_small_discriminator_en/1", | ||
| }, | ||
| "electra_small_generator_en": { | ||
| "metadata": { | ||
| "description": ( | ||
| "ELECTRA: Pre-training Text Encoders as Discriminators Rather Than Generators" | ||
| "This is small generator model with 12 layers." | ||
| ), | ||
| "params": 13548800, | ||
| "official_name": "ELECTRA", | ||
| "path": "electra", | ||
| "model_card": "https://github.com/google-research/electra", | ||
| }, | ||
| "kaggle_handle": "kaggle://pranavprajapati16/electra/keras/electra_small_generator_en/1", | ||
| }, | ||
| "electra_base_generator_en": { | ||
| "metadata": { | ||
| "description": ( | ||
| "ELECTRA: Pre-training Text Encoders as Discriminators Rather Than Generators" | ||
| "This is base generator model with 12 layers." | ||
| ), | ||
| "params": 33576960, | ||
| "official_name": "ELECTRA", | ||
| "path": "electra", | ||
| "model_card": "https://github.com/google-research/electra", | ||
| }, | ||
| "kaggle_handle": "kaggle://pranavprajapati16/electra/keras/electra_base_generator_en/1", | ||
| }, | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything at https://www.kaggle.com/models/pranavprajapati16/electra.
You should now have the ability to make models public, can you do so? Or is the actual model here? https://www.kaggle.com/models/pranavprajapati16/electra_base_discriminator_en (in which case these links are still wrong).
Let me know where to get the proper assets and I will copy to the Keras org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the model was private just made it public. https://www.kaggle.com/models/pranavprajapati16/electra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Uploading now! I can just patch the new links into this PR and land. I'll ping here if I run into any issues.