Run workflows with read-only tokens #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
Member
|
/gcbrun |
mattdangerw
approved these changes
Nov 8, 2023
Member
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
This looks good to me! Let us know if you think we should merge this along with the setting change in #1304. That seems good, as as these workflow will never need write whatever our setting our, but I will wait for you to weigh in.
Contributor
Author
|
Yeah, the repo setting ensures the default is secure, but this gives you an added layer of security in case someone accidentally changes the setting back (which happens more often than you'd think, since many third-party Actions simply suggest setting write-all instead of figuring out which permissions they actually need). It also has the slight benefit of helping security tools such as the OpenSSF Scorecard know the workflow is secure. |
Member
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1304.
This PR ensures all KerasNLP workflows run with read-only tokens, protecting the project from supply-chain risks.