Convert T5 to Keras 3 #1274
Merged
Convert T5 to Keras 3 #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mattdangerw
requested changes
Oct 18, 2023
| from keras_nlp.backend import ops | ||
|
|
||
|
|
||
| def shape_list(tensor): |
There was a problem hiding this comment.
we can probably just remove this whole function and use ops.shape where ever it was used.
There was a problem hiding this comment.
Fixed, sorry left over while debugging!
| mask_positions, | ||
| mask_ids, | ||
| ) = tf_text.mask_language_model( | ||
| (token_ids, mask_positions, mask_ids,) = tf_text.mask_language_model( |
There was a problem hiding this comment.
this looks like you are using an older version of black maybe?
if you remove the trailing comma it would reformat to one line
There was a problem hiding this comment.
Fixed! Yeah just needed to update black
|
/gcbrun |
|
this failure here is xlm-roberta causing an occasional oom. maybe we should just comment that test out for now, it's probably the big embedding eating all available ram. anyway, unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all TF ops with Keras ops, making T5 work multi-backend.