Remove unused TPU testing for backbones #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPU testing would be great, but we should not do it quite like this. - These are not run in any form of CI right now. Do they run at all? I don't think anyone has tried these for many months. - They basically replicate the simplest tests from the main fixture inside a TPU strategy scope. We would be much better off handling this inside some common test setup, rather than replicating test code. - They would not work multi-backend. - They do not test presets, tasks, backprop, and a lot of the actual important functionality for our pretrained model offering. Let's remove for now as I consolidate our preset testing code. We can bring this back later when we have a plan to run these in a more sustainable way for our test suite.
ianstenbit
approved these changes
Oct 6, 2023
mattdangerw
added a commit
that referenced
this pull request
Nov 7, 2023
TPU testing would be great, but we should not do it quite like this. - These are not run in any form of CI right now. Do they run at all? I don't think anyone has tried these for many months. - They basically replicate the simplest tests from the main fixture inside a TPU strategy scope. We would be much better off handling this inside some common test setup, rather than replicating test code. - They would not work multi-backend. - They do not test presets, tasks, backprop, and a lot of the actual important functionality for our pretrained model offering. Let's remove for now as I consolidate our preset testing code. We can bring this back later when we have a plan to run these in a more sustainable way for our test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPU testing would be great, but we should not do it quite like this.
Let's remove for now as I consolidate our preset testing code. We can bring this back later when we have a plan to run these in a more sustainable way for our test suite.