Fix t5 forward pass #1082
Merged
Fix t5 forward pass #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was noticed on keras-team#900, but we should probably get the fix into the forward pass without waiting on checkpoints.
Member
Author
|
/gcbrun |
jbischof
approved these changes
Jun 16, 2023
Contributor
jbischof
left a comment
jbischof
left a comment
There was a problem hiding this comment.
Could you add a link to the original discussion? Can't find it.
Member
Author
|
No convo to link out directly. But this was a straight typo introduced by yours truly. Chatted some with Francois forever ago to debug it. Became obvious on #900, with this fix the checkpoints outputs match, without they are far off. There is no use case for the current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed on #900, but we should probably get the fix into the forward pass without waiting on checkpoints.