Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX #2322

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

sampathweb
Copy link
Collaborator

@sampathweb sampathweb commented Jan 29, 2024

TensorFlow tests are failing for unrelated issues - see #2321.

@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Jan 29, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Jan 29, 2024
@sampathweb sampathweb changed the title Fix CI Test for Basnet OOM Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX Jan 30, 2024
@sampathweb sampathweb changed the title Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX [WIP] Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX Jan 30, 2024
@sampathweb sampathweb changed the title [WIP] Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX Jan 30, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Jan 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Jan 30, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Jan 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Jan 30, 2024
Copy link
Contributor

@tirthasheshpatel tirthasheshpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's tackle the tensorflow error in a follow-up. It was failing for SegFormer before but now fails with DeepLabV3. Pretty sure it's an OOM but PyTest's multi-threading is getting in the way of TensorFlow's exception handling.

@tirthasheshpatel tirthasheshpatel merged commit d04fbcc into keras-team:master Jan 30, 2024
9 of 10 checks passed
@sampathweb sampathweb deleted the fix-ci-test-basnet branch January 30, 2024 21:00
sampathweb added a commit that referenced this pull request Jan 31, 2024
* Move keras-cv markdown files to toplevel (#2291)

Keras, KerasNLP and KerasTuner all store things liek the CONTRIBUTING.md
in the toplevel of the repo. We should do the same here.

* Add `version()` API to unify with Keras and KerasNLP (#2199)

* Unify `version` API with keras and keras_nlp

* Formatting

* Update to keep `version` parity with KerasNLP, support nightly version string

* Update version_utils.py

* Update version_utils.py

* Update random_crop_and_zoom.py (#2294)

* Update random_crop_and_zoom.py

* Update description

* rename file

* bug fix (#2303)

* Add BASNet Segmentation Model (#2006) (#2271)

* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet

* Fix image.shape type (#2305)

Fixed image.shape issue for tensorflow backend

* Create workflow for auto assignment of issues and for stale issues (#2313)

* Create auto-assignment.yaml

* Create auto-assignment.js

* Create stale-issue-pr.yaml

* Rename auto-assignment.yaml to auto-assignment.yml

* Rename stale-issue-pr.yaml to stale-issue-pr.yml

* Fix format and Update Vectorized Base (#2323)

* Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX (#2322)

* Reduce memory consumption for BasNet tests (#2325)

---------

Co-authored-by: Matt Watson <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>
Co-authored-by: Sachin Prasad <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Hamid Ali <[email protected]>
Co-authored-by: Tirth Patel <[email protected]>
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants