Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keras 3 version check #2191

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

sampathweb
Copy link
Collaborator

from tensorflow import keras doesn't work for TF 2.14 and Keras 3.

keras-nlp has a function to check if TensorFlow uses Keras 3 via -
https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/backend/config.py#L66

This works when using tf-nightly or TensorFlow 2.15, but breaks on TensorFlow 2.14 which is the default in Colab. To fix it, use import keras instead of from tensorflow import keras when doing this check.

Colab to repro the issue:
https://colab.research.google.com/drive/17AwBX5S29d-hjUDPLN8roHSNzrjXricG?usp=sharing

@sampathweb sampathweb requested review from mattdangerw and fchollet and removed request for fchollet November 26, 2023 22:53
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sampathweb sampathweb merged commit 925d99d into keras-team:master Nov 28, 2023
6 of 9 checks passed
@sampathweb sampathweb deleted the fix-keras3-check branch November 28, 2023 03:13
sampathweb added a commit that referenced this pull request Dec 6, 2023
* Fix Keras 3 version check

* Fix Keras 3 version check

* Fix Keras 3 version check

* Raise error if Keras is not compatible with TF
sampathweb added a commit that referenced this pull request Dec 6, 2023
* Fix Keras 3 version check (#2191)

* Fix Keras 3 version check

* Fix Keras 3 version check

* Fix Keras 3 version check

* Raise error if Keras is not compatible with TF

* Fix bug when upranking passthrough inputs to RandAugment (#2194)

- RandAugment sometimes will choose a "no augmentation" option and
  passthrough inputs unaltered.
- Preprocessing normalization routines were not making copies of inputs
  and sometimes mutating layer input directly (mutating the input
  dict to cast dtypes and uprank tensors).
- RandAugment under the passthrough option would return these inputs
  directly.

The net effect was sometimes attempting to uprank during a passthrough
call, breaking tf.map_fn

* fix stable diffusion rank error (#2208)

* Simplify running KerasCV with Keras 3 (#2179)

* remove keras_core dependency

* update init

* update readme

* fix model None error (#2176) (#2177)

* Update pycoco_callback.py

* Update waymo_evaluation_callback.py

* fix model None error (#2176) (#2178)

* Update pycoco_callback.py

* Update waymo_evaluation_callback.py

* update readme and conftest

* update readme

* update citation list

* fix mix transformer tests

* fix lint error

* fix all failing tests

* Fix dtype support for SegmentAnythingModel (#2207)

* Fix dtype support for SAM

* Update keras_cv/models/segmentation/segment_anything/sam_test.py

* Fix Keras 2 failures

* Fix F401 lint error; remove unused import

* Version bump to r0.7.2.dev0

---------

Co-authored-by: Matt Watson <[email protected]>
Co-authored-by: Divyashree Sreepathihalli <[email protected]>
Co-authored-by: Tirth Patel <[email protected]>
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
* Fix Keras 3 version check

* Fix Keras 3 version check

* Fix Keras 3 version check

* Raise error if Keras is not compatible with TF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants