-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly specify full package for more modules, as shown in #2001 #2077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix!
Hi @BjarneHerland -- please take a look at the linter error
Thanks again for the fix! |
e630765
to
328fc88
Compare
Thanks @BjarneHerland. What behavior does this change? |
328fc88
to
3bd888e
Compare
No problem 👍 It resolves the issue seen in #2070 by following the lead from #2001 On a clean checkout master without this fix, running e.g.
bombs out with naming collisions. (It puzzles me why registration is done like this though, but #2001 was accepted, so I follow... 🤷 We could probably fix |
/gcbrun |
Something seems to have changed recently (improved lazy-loading?) but this import still triggers the issue for me
|
3bd888e
to
6d0d570
Compare
/gcbrun |
Looks like we've still got some linter errors:
You can run the linter locally by running |
6d0d570
to
9c79dd8
Compare
Yeah - forgot to do that for the test 😒 Sorry! |
…eam#2001 (keras-team#2077) * Test to demonstrate failures in import * Explicitly specify full package for more modules, as shown in keras-team#2001
…eam#2001 (keras-team#2077) * Test to demonstrate failures in import * Explicitly specify full package for more modules, as shown in keras-team#2001
Explicitly specify full package-name for several methods upon registering as serialisable.
Fixes #2070
Before submitting
Pull Request section?
to it if that's the case.