Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of segmentation mask in RandomShear Layer #2021

Merged
merged 9 commits into from
Aug 22, 2023

Conversation

cosmo3769
Copy link
Contributor

What does this PR do?

Related #1992

Add support of segmentation mask in Augmix layer. Here is the colab link for demo.

Output generated by demo:

Screenshot 2023-08-11 at 8 23 29 PM

Who can review?

@ianstenbit

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small fix!

Thank you for the PR!

keras_cv/layers/preprocessing/random_shear.py Outdated Show resolved Hide resolved
@ianstenbit
Copy link
Contributor

/gcbrun

segmentation_masks = preprocessing.transform(
images=segmentation_masks,
transforms=transforms_y,
interpolation=self.interpolation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops -- looks like we missed one here -- this should also be "nearest"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I missed that. 😅

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we missed one more little thing -- thanks!

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you!

@ianstenbit ianstenbit merged commit f3c6294 into keras-team:master Aug 22, 2023
6 of 9 checks passed
@cosmo3769 cosmo3769 deleted the randomshear-segmentation-mask branch September 11, 2023 11:27
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
)

* seg mask support

* format

* add test

* add demo

* fix

* update readme

* review comment

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants