Possible indentation error

[ariG23498]

With the following code it seems that the first roi would return the regions.

keras-cv/keras_cv/layers/object_detection/roi_pool.py

Line 159 in 0c6944f

return regions

If this is correct, I would send in a PR for this fix.

[ariG23498]

I wanted to report another issue in this thread.

Using the

feature_map = tf.random.normal([2, 16, 16, 512])
roi_pooler = ROIPooler(
    bounding_box_format="yxyx", target_size=[7, 7], image_shape=[224, 224, 3]
)
rois = tf.constant(
    [
        [[15.0, 30.0, 25.0, 45.0], [16.0, 31.0, 26.0, 46.0]],
        [[22.0, 1.0, 30.0, 32.0], [23.0, 2.0, 31.0, 33.0]],
    ],
)
print(f"{feature_map.shape=}")
print(f"{rois.shape=}")
pooled_feature_map = roi_pooler(feature_map, rois)
print(f"{pooled_feature_map.shape=}")

# feature_map.shape=TensorShape([2, 16, 16, 512])
# rois.shape=TensorShape([2, 2, 4])
# pooled_feature_map.shape=TensorShape([2, 7, 7, 512])

Notice how the pooled_feature_map.shape does not conside the number of rois.

GitHub Gist

CC: @divyashreepathihalli

This issue directly affects the #2295

[divyashreepathihalli]

Looks like a bug, do you have a fix PR?

[ariG23498]

Unfortunately I do not.

[divyashreepathihalli]

Fixed.