Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement readability and comprehensibility of cast process of generate_image() in Stable Diffusion #2195

Closed
y-vectorfield opened this issue Nov 28, 2023 · 2 comments
Closed

Improvement readability and comprehensibility of cast process of generate_image() in Stable Diffusion #2195

y-vectorfield opened this issue Nov 28, 2023 · 2 comments
Assignees
@sachinprasadhs
Labels
keras-team-review-pending type:Bug Something isn't working

Comments

@y-vectorfield
Copy link
Contributor

According to line 238, the casting method is implemented abruptly and unnaturally.
I added this method previously in pull request #2102.
Hence, I should move this method to line 237 and add comments about the reason for the casting.

keras-cv/keras_cv/models/stable_diffusion/stable_diffusion.py

Line 238 in 925d99d

latent = ops.cast(latent, latent_prev.dtype)

y-vectorfield added a commit to y-vectorfield/keras-cv that referenced this issue Nov 28, 2023
@y-vectorfield
Fix the issue(keras-team#2195): Improve readability and comprehensibi…
0d24ac4 
…lity of stable diffusion source
y-vectorfield added a commit to y-vectorfield/keras-cv that referenced this issue Nov 28, 2023
@y-vectorfield
Fix the issue(keras-team#2195): Improve readability and comprehensibi…
f243684 
…lity of Stable Diffusion source
y-vectorfield added a commit to y-vectorfield/keras-cv that referenced this issue Nov 28, 2023
@y-vectorfield
Fix the issue(keras-team#2195): Improve readability and comprehensibi…
9414c7e 
…lity of Stable Diffusion source
@sachinprasadhs sachinprasadhs self-assigned this Dec 4, 2023
divyashreepathihalli pushed a commit that referenced this issue Dec 11, 2023
@y-vectorfield
Fix the issue(#2195): Improve readability and comprehensibility of St…
e4fbbe0 
…able Diffusion source (#2197)
@divyashreepathihalli
Copy link
Collaborator

changes merged

@y-vectorfield
Copy link
Contributor Author

@divyashreepathihalli, thank you very much!

yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this issue Feb 8, 2024
@y-vectorfield @yuvraj-wale
Fix the issue(keras-team#2195): Improve readability and comprehensibi…
c332456 
…lity of Stable Diffusion source (keras-team#2197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinprasadhs sachinprasadhs

Labels
keras-team-review-pending type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@y-vectorfield @sachinprasadhs @divyashreepathihalli