Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Commit

Permalink
Corrections suggested by Scrutinizer
Browse files Browse the repository at this point in the history
  • Loading branch information
ker0x committed Dec 1, 2015
1 parent 534a8a9 commit 3584ea4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
18 changes: 8 additions & 10 deletions Controller/Component/GcmComponent.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,9 @@ public function initialize(Controller $controller) {
* send method
*
* @param string|array $ids
* @param array $data
* @param array $payload
* @param array $parameters
* @param string $field
* @return void
* @return boolean
*/
public function send($ids = false, $payload = array(), $parameters = array()) {

Expand Down Expand Up @@ -149,7 +148,7 @@ public function send($ids = false, $payload = array(), $parameters = array()) {
* @param string|array $ids
* @param array $notification
* @param array $parameters
* @return void
* @return boolean
*/
public function sendNotification($ids = false, $notification = array(), $parameters = array()) {
return $this->send($ids, array('notification' => $notification), $parameters);
Expand All @@ -161,7 +160,7 @@ public function sendNotification($ids = false, $notification = array(), $paramet
* @param string|array $ids
* @param array $data
* @param array $parameters
* @return void
* @return boolean
*/
public function sendData($ids = false, $data = array(), $parameters = array()) {
return $this->send($ids, array('data' => $data), $parameters);
Expand All @@ -170,7 +169,7 @@ public function sendData($ids = false, $data = array(), $parameters = array()) {
/**
* response method
*
* @return void
* @return string
*/
public function response() {
if (array_key_exists($this->_response->code, $this->_errorMessages)) {
Expand Down Expand Up @@ -211,13 +210,12 @@ protected function _executePush($notification = false) {
}

/**
* _buildNotification method
* _buildMessage method
*
* @param array $ids
* @param array $data
* @param array $payload
* @param array $parameters
* @param string $field
* @return json
* @return false|string
*/
protected function _buildMessage($ids = false, $payload = false, $parameters = false) {
if ($ids === false) {
Expand Down
2 changes: 1 addition & 1 deletion Controller/GcmAppController.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class GcmAppController extends AppController {
*
* @var array
*/
public $helpers = array(
public $helpers = array(
'Html',
'Form'
);
Expand Down

0 comments on commit 3584ea4

Please sign in to comment.