Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Feature Request: Fall back to service resources if no stage specific resource is found. #3

Closed
checkelmann opened this issue May 4, 2020 · 1 comment

Comments

@checkelmann
Copy link

Hi,

when adding the JMeter tests as project resource like

keptn add-resource --project=$PROJECT_NAME --resource=basiccheck.jmx --resourceUri=jmeter/basiccheck.jmx    
keptn add-resource --project=$PROJECT_NAME --resource=load.jmx --resourceUri=jmeter/load.jmx    

The tests are not getting executed with the message Skipping test execution because no tests have been defined..

{"timestamp":"2020-05-04T16:06:01.391533497Z","logLevel":"INFO","message":"No jmeter/jmeter.conf.yaml file found for service sampleapp in stage dev01 in project sampleapp"}
{"timestamp":"2020-05-04T16:06:01.391594867Z","logLevel":"INFO","message":"Running workload testStrategy=healthcheck, vuser=1, loopcount=1, thinktime=250, funcvalidation=false, acceptederrors=0.000000, avgrtvalidation=0, script=jmeter/basiccheck.jmx"}
{"timestamp":"2020-05-04T16:06:01.400140918Z","logLevel":"DEBUG","message":"Skipping test execution because no tests have been defined."}
{"timestamp":"2020-05-04T16:06:01.400177644Z","logLevel":"INFO","message":"Health Check test passed = true. Project: sampleapp, Service: sampleapp, Stage: dev01, TestStrategy: functional"}
{"timestamp":"2020-05-04T16:06:01.400206431Z","logLevel":"INFO","message":"Running workload testStrategy=functional, vuser=1, loopcount=1, thinktime=250, funcvalidation=true, acceptederrors=0.100000, avgrtvalidation=0, script=jmeter/load.jmx"}
{"timestamp":"2020-05-04T16:06:01.409462052Z","logLevel":"DEBUG","message":"Skipping test execution because no tests have been defined."}
{"timestamp":"2020-05-04T16:06:01.409491502Z","logLevel":"INFO","message":"Tests for functional with status = true.Project: sampleapp, Service: sampleapp, Stage: dev01, TestStrategy: functional"}

Please see the code segment here:
https://github.com/keptn-contrib/jmeter-extended-service/blob/master/jmeterUtils.go#L47

I need to add the resources with service and stage parameter like keptn add-resource --project=sampleapp --service=sampleapp --stage=dev01 --resource=basiccheck.jmx --resourceUri=jmeter/basiccheck.jmx.

It would be beneficial if the JMeter-service tries to fall back and load the project level resources if no service and stage-specific resources are found.

Thanks!

grabnerandi added a commit that referenced this issue May 6, 2020
@grabnerandi
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants