Skip to content

chore: parametize debian codename #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: parametize debian codename #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347413a
chore: parametize debian codename
AkashKumar7902 Sep 22, 2025
1c55d2e
fix: add DNS/NSS configuration to Dockerfile
AkashKumar7902 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions flask-mongo/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,43 @@
# Use the official Python image as the base image
FROM python:3.9
# Define an argument for the Debian version with a default value
# This allows you to build for a specific version, e.g., bullseye, bookworm, or trixie
ARG DEBIAN_VERSION=bookworm
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a more stable default like 'bullseye' instead of 'bookworm'. The 'bookworm' codename refers to Debian 12 which is relatively new, and using 'bullseye' (Debian 11) as default would provide better stability for production environments.

Suggested change
ARG DEBIAN_VERSION=bookworm
ARG DEBIAN_VERSION=bullseye

Copilot uses AI. Check for mistakes.

# Set the working directory within the container
# Use the argument in the FROM instruction
FROM python:3.9-slim-${DEBIAN_VERSION}

# --- DNS/NSS fix (bullseye-slim often lacks these) ---
RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
libnss-dns libnss-files netbase ca-certificates && \
rm -rf /var/lib/apt/lists/*; \
# Ensure glibc actually consults DNS
if ! grep -q '^hosts:.*\bdns\b' /etc/nsswitch.conf 2>/dev/null; then \
echo 'hosts: files dns' > /etc/nsswitch.conf; \
fi

# Set the working directory
WORKDIR /app

# Copy the application code into the container
# Create a non-root user to run the application
RUN addgroup --system appgroup && adduser --system --ingroup appgroup appuser

# Copy the requirements file and install dependencies
# This is done first to leverage Docker's layer caching
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The COPY instruction assumes requirements.txt exists in the build context. Consider adding error handling or documentation about this requirement, as the build will fail if the file doesn't exist.

Suggested change
# This is done first to leverage Docker's layer caching
# This is done first to leverage Docker's layer caching
# NOTE: requirements.txt must exist in the build context (the directory you run `docker build` from).
# If it is missing, the build will fail at this step.

Copilot uses AI. Check for mistakes.
COPY requirements.txt .
RUN pip install --no-cache-dir -r requirements.txt

# Copy the rest of the application code
COPY . .

# Install the required packages
RUN pip3 install -r requirements.txt
# Change ownership of the app directory to the non-root user
RUN chown -R appuser:appgroup /app

# Switch to the non-root user
USER appuser

# Expose the port that the Flask app will run on
EXPOSE 6000

# Start the Flask application
CMD ["python3", "app.py"]
CMD ["python3", "app.py"]