Skip to content

Conversation

kaushiktak19
Copy link
Contributor

@kaushiktak19 kaushiktak19 commented Oct 16, 2025

What has changed?

Implemented proper dark mode styling for src/components/InstallReminder.js and src/components/EnterpriseInstallReminder.js (dark background, border, shadow and text colors).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Ran npm run build and npm run serve to check if the changes are working as expected.

Build Check :
Screenshot 2025-10-16 170735

Changes :

  • Before :
Screenshot 2025-10-16 171515 Screenshot 2025-10-16 171520
  • After :
Screenshot 2025-10-16 171732 Screenshot 2025-10-16 171727

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaushiktak19 can you please make the same change in the EnterpriseInstallReminder?? it is newly created you can use this same styling in that component

@kaushiktak19
Copy link
Contributor Author

Okay @Achanandhi-M , have made those changes -

Screenshot 2025-10-16 180821 Screenshot 2025-10-16 180829

@kaushiktak19 kaushiktak19 changed the title ui: dark mode for installation component fixed ui: dark mode for installation components fixed Oct 16, 2025
Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaushiktak19 I have reviewed your PR, changes are really good but can you please make the text properly aligned currently, the text inside the box is not good

@kaushiktak19
Copy link
Contributor Author

Hey @kaushiktak19 I have reviewed your PR, changes are really good but can you please make the text properly aligned currently, the text inside the box is not good

Sure @Achanandhi-M , by align are u addressing the the extra space above first line, top margin ? or its soemthing else, if u could clarify.

@Achanandhi-M
Copy link
Contributor

Hey @kaushiktak19 I have reviewed your PR, changes are really good but can you please make the text properly aligned currently, the text inside the box is not good

Sure @Achanandhi-M , by align are u addressing the the extra space above first line, top margin ? or its soemthing else, if u could clarify.

yes, the content is not properly aligned there is no equal spaces

@kaushiktak19
Copy link
Contributor Author

@Achanandhi-M , Is this fine ?

Screenshot 2025-10-16 183935 Screenshot 2025-10-16 183944

@Achanandhi-M
Copy link
Contributor

@Achanandhi-M , Is this fine ?

Screenshot 2025-10-16 183935 Screenshot 2025-10-16 183944

Good one @kaushiktak19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants