-
Notifications
You must be signed in to change notification settings - Fork 246
dark theme issue solved #2986 #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
|
@Achanandhi-M, I've resolved the dark mode styling issue in the Keploy Installation component. Could you please review the changes? Thanks! |
04c28a2 to
13d3523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AzhaanGlitch thanks for raising the PR, can you please change colour in the dark mode it is not really good
Yaa sure, I will make it look more catchy. |
94d54ea to
5332113
Compare
|
Hello @Achanandhi-M, thank you for your feedback on the PR. I have made the necessary color adjustments for dark mode as requested. Please review the changes and let me know if there are any further modifications needed. |
|
Hey @AzhaanGlitch, I’ve reviewed your PR. The design currently looks a bit too dark, and I think it could be improved further. Could you please adjust it to make it look even better? |
eacdf57 to
de13bae
Compare
|
Hello @Achanandhi-M, thank you for your feedback on the PR. I have made the necessary color adjustments for dark mode as requested. Please review the changes. |
Signed-off-by: Azhaan Ali Siddiqui <[email protected]>
Signed-off-by: Azhaan Ali Siddiqui <[email protected]>
Signed-off-by: Azhaan Ali Siddiqui <[email protected]>
Signed-off-by: Azhaan Ali Siddiqui <[email protected]>
a73429e to
7acee2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AzhaanGlitch,
I don’t think any changes are needed in the custom.css file to fix the issue with the dark installation component. Could you please explain why those changes were made in custom.css?
|
Hi @Achanandhi-M , |
|
Hey @AzhaanGlitch , thank you so much for raising this PR! 🙌 We’ve already merged similar changes from another contributor, so we’ll be closing this one. We really appreciate your effort and would love for you to pick a new good first issue — your contributions are always welcome! 💛 |

InstallReminder Component UI Bug Fix
Overview
This project addresses a UI bug in the
InstallRemindercomponent where the heading and paragraph text remained dark in dark mode, causing readability issues against the dark background.Changes Made
InstallReminder.jscomponent to ensure theme adaptability.install-reminder-containerinstall-reminder-buttoncustom.cssstylesheet.[data-theme='dark']rule to adjust the component's background and text colors for dark mode, ensuring proper visibility.Issue Resolution
This pull request resolves issue keploy/keploy#2986
Type of Change
Testing
The changes were tested by:
npm run buildandnpm run servelocally.InstallRemindercomponent renders correctly in both light and dark themes.Screenshots
Checklist