Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big update to allow ifspeed for slow interfaces. #645

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Dec 18, 2023

Closes #643

Look at supporting ifSpeed when we need to for interface speed. Need to think through what can go wrong here.

@i3149 i3149 added the wip Work In Progress label Dec 18, 2023
@i3149 i3149 force-pushed the allow-ifspeed-slow-ints branch from 593bf83 to 5eee57b Compare January 11, 2024 05:08
@i3149 i3149 requested a review from thezackm January 30, 2024 04:12
@i3149
Copy link
Contributor Author

i3149 commented Jan 30, 2024

I think this at least will not break existing behavior. User reported that its working for them in staging so let me know what you think @thezackm

pkg/formats/util/util.go Outdated Show resolved Hide resolved
@thezackm
Copy link
Contributor

thezackm commented Feb 1, 2024

@i3149 - looks good; curious if there would be a situation on these older devices where other "high" metrics ifHCInOctets, ifHCOutOctets, etc. would be missing as well.

@i3149
Copy link
Contributor Author

i3149 commented Feb 2, 2024

@i3149 - looks good; curious if there would be a situation on these older devices where other "high" metrics ifHCInOctets, ifHCOutOctets, etc. would be missing as well.

These are actually covered in the profiles. You added these override blocks: https://github.com/kentik/snmp-profiles/blob/main/profiles/kentik_snmp/_general/if32-mib.yml#L21

So that the 32bit counters are reported as ifHCInOctets and so on. As far as ktrans thinks, everyone everywhere supports high metrics. Just the annoying speed which isn't.

thezackm
thezackm previously approved these changes Feb 2, 2024
@i3149 i3149 merged commit 7dc6116 into main Feb 2, 2024
1 check passed
@i3149 i3149 deleted the allow-ifspeed-slow-ints branch February 2, 2024 07:02
i3149 added a commit that referenced this pull request Feb 6, 2024
i3149 added a commit that referenced this pull request Feb 6, 2024
@khara-NewRelic
Copy link

Hi, my customer has started monitoring for Fujitsu and Yamaha network devices with custom profiles. Then, they has faced this issue of low interface data derived from the devices. The release covering this issue is very important to support their network operation. When is the release scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Calculation of IfInUtilization and IfOutUtilization using items collected by SNMP MIB-2 Interfaces
3 participants