Skip to content

Consolidate low-signal tests from recent integrations and jobs work - #982

Merged
kody-bot merged 2 commits into
mainfrom
cursor/test-quality-guidelines-392d
Jul 27, 2026
Merged

kody-bot merged 2 commits into
mainfrom
cursor/test-quality-guidelines-392d

Conversation

@cursor

@cursor cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Agents added many verification tests while shipping OAuth apps/connections (#979), job retention/filters (#973/#975), durable publish escalation (#976), reindex D1 retries (#978), storage-bucket ownership (#965), and related MCP/Sentry carve-outs. This pass folds those suites toward the repo testing principles: fewer longer workflow tests, structured contracts over copy pins, and no one-case-per-filter / duplicate Playwright coverage.

Changes

  • Integrations: merge OAuth app setup/reuse/prefill matrices and account-integrations loader journeys; drop SQL predicate alias pin
  • Reindex / remote connector: fold retry+exhaustion pairs; merge hello invalid/transient/hard-failure outcomes; keep page-walk tests separate
  • Account jobs: one filter unit journey + one E2E list/filter/detail journey
  • Values/secrets/MCP servers: merge reserved-prefix and plan-quota workflows; stop pinning instructional error copy
  • Durable publish: drop redundant force/non-force escalation case (covered by publish idempotency parts)
  • Entitlements: rewrite package_service_states backfill fixture to exercise real rescue instead of empty no-op
  • Delete run-history-legacy-guardrail.node.test.ts source-scan regression

Net: 46 fewer test() cases, −569 lines across 22 files. Behavior under test is unchanged.

System recap — composes existing primitives (low risk)

Mode: recap · Base: main @ f8803a0f · Head: 7cdaf04d

Classification: composes — test-only consolidation; no production behavior, contracts, or primitives changed.

Primitives touched

Primitive Group Impact
integrations assistant composes — OAuth app/setup test journeys
app-ui surfaces composes — account jobs/integrations filter tests
jobs assistant composes — reindex retry journey
connector-ingress surfaces composes — hello/secret-lookup outcomes
mcp-client-servers assistant composes — OAuth callback + server resolve
mcp-server surfaces composes — values/secrets/publish test trim
capability-registry assistant composes — durable escalation journey
entitlements auth composes — backfill fixture rewrite
storage-buckets storage composes — register/list journey

System map

Test-only consolidation across recent OAuth, jobs, connector, and MCP suites — no production edges change.

Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).

flowchart LR
	integrations["integrations<br/>OAuth integrations"]:::touched
	appUi["app-ui<br/>Browser app"]:::touched
	jobs["jobs<br/>Scheduled jobs"]:::touched
	connectorIngress["connector-ingress<br/>Remote connector ingress"]:::touched
	mcpClientServers["mcp-client-servers<br/>MCP client servers"]:::touched
	mcpServer["mcp-server<br/>MCP endpoint"]:::touched
	classDef touched fill:#1a7f37,color:#fff
	classDef extended fill:#9a6700,color:#fff
	classDef added fill:#cf222e,color:#fff
	classDef untouched fill:#57606a,color:#fff
Loading
Open in Web View Automation 

cursoragent and others added 2 commits July 27, 2026 09:08
… work

Fold post-#958 verification tests toward fewer longer workflow journeys:
merge OAuth app/setup/prefill matrices, reindex retry pairs, remote-connector
hello/secret lookup outcomes, account jobs filter+e2e journeys, and plan
secret quota cases. Drop the run-history source-scan guardrail and SQL
predicate alias pin; rewrite the package_service_states backfill fixture to
exercise real rescue behavior instead of the empty no-op path.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
The merged D1-retry journey reused the successful upsert spy in the
exhaustion path, so the not-called assertion failed spuriously.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kody-bot
kody-bot marked this pull request as ready for review July 27, 2026 09:09
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-982.kody-a99.workers.dev

Worker: kody-pr-982
D1: kody-pr-982-db
KV: kody-pr-982-oauth-kv

Mocks:

@kody-bot
kody-bot merged commit e508c8f into main Jul 27, 2026
16 checks passed
@kody-bot
kody-bot deleted the cursor/test-quality-guidelines-392d branch July 27, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants