Consolidate low-signal tests from recent integrations and jobs work - #982
Merged
Merged
Conversation
… work Fold post-#958 verification tests toward fewer longer workflow journeys: merge OAuth app/setup/prefill matrices, reindex retry pairs, remote-connector hello/secret lookup outcomes, account jobs filter+e2e journeys, and plan secret quota cases. Drop the run-history source-scan guardrail and SQL predicate alias pin; rewrite the package_service_states backfill fixture to exercise real rescue behavior instead of the empty no-op path. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
The merged D1-retry journey reused the successful upsert spy in the exhaustion path, so the not-called assertion failed spuriously. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
July 27, 2026 09:09
Contributor
|
🔎 Preview deployed: https://kody-pr-982.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents added many verification tests while shipping OAuth apps/connections (#979), job retention/filters (#973/#975), durable publish escalation (#976), reindex D1 retries (#978), storage-bucket ownership (#965), and related MCP/Sentry carve-outs. This pass folds those suites toward the repo testing principles: fewer longer workflow tests, structured contracts over copy pins, and no one-case-per-filter / duplicate Playwright coverage.
Changes
run-history-legacy-guardrail.node.test.tssource-scan regressionNet: 46 fewer
test()cases, −569 lines across 22 files. Behavior under test is unchanged.System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@f8803a0f· Head:7cdaf04dClassification: composes — test-only consolidation; no production behavior, contracts, or primitives changed.
Primitives touched
integrationsapp-uijobsconnector-ingressmcp-client-serversmcp-servercapability-registryentitlementsstorage-bucketsSystem map
Test-only consolidation across recent OAuth, jobs, connector, and MCP suites — no production edges change.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).