Repository navigation
fix(mcp): stop reporting sandbox execute failures to Sentry - #918
kentcdodds wants to merge 2 commits into
Conversation
Caller/module errors (bad Notion filters, thrown strings, syntax issues) already land on mcp-event logs. Sending them to Sentry as warnings opens noise issues that look like platform bugs and trip triage automation.
KODY-CLOUDFLARE-1N reported Unknown: b[t]?.title?.map is not a function from mcp.sandbox_error execute; assert that path skips Sentry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMCP sandbox failures now remain in event logs without Sentry reporting. Non-sandbox failures continue through Sentry exception capture with error-level scope configuration, and tests cover both routing paths. ChangesMCP observability
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-918.kody-a99.workers.dev Worker: Mocks:
|
Summary
Sentry issue KODY-CLOUDFLARE-1N is a warning with tags
mcp.sandbox_error=true/mcp.tool=execute: an MCPexecutecaller/module threw the non-Error stringb[t]?.title?.map is not a function(minified user/package code). That is not a platform defect.The same root cause class already has a draft sibling PR (#915 / KODY-CLOUDFLARE-1H). This PR lands the filter so sandbox failures stay on structured
mcp-eventlogs and no longer open Sentry warning issues that trip triage automation. Platform MCP failures still report at error level.Sibling sandbox-noise issues sharing
mcp.sandbox_error:true(e.g. missing secrets, bad Notion paths, invokeChecked param errors) are addressed by the same change.Test plan
observability.node.test.tsasserts sandbox failures still emitmcp-eventbut do not callcaptureMessage/captureException, using the 1N error signatureSystem recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@49893e20· Head:37ae7f38Classification: extends — changes MCP failure reporting so sandbox/user-module errors stay on logs only and no longer open Sentry issues.
Primitives touched
mcp-serverSystem map
Sandbox execute failures used to become Sentry warnings via MCP observability; they now stay on the
mcp-eventlog path only.Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context.
Before / after
Before: execute sandbox failures (
sandboxError: true) were captured in Sentry as warnings (Unknown: …), including thrown strings from caller modules such asb[t]?.title?.map is not a function.After: sandbox failures remain on
mcp-eventlogs; only non-sandbox MCP failures are sent to Sentry at error level.Risk and invariants
Docs
No doc updates; behavior is an observability policy change covered by unit tests.
Summary by CodeRabbit