Repository navigation
Fix MCP init crash on remote connector snapshot timeout - #914
Conversation
Capability registry already soft-failed stalled connectors, but MCP session init still loaded instruction summaries without a catch, so a 5s snapshot timeout aborted the whole /mcp Durable Object handshake.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe remote connector instruction summary loader moves into a dedicated module. MCP initialization imports the helper, and a new test verifies stalled connector snapshots do not prevent healthy connector summaries from being returned. ChangesRemote connector summaries
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-914.kody-a99.workers.dev Worker: Mocks:
|
Summary
Sentry KODY-CLOUDFLARE-1D:
RemoteConnectorSnapshotTimeoutErrorfor connector"home"was aborting/mcpsession setup.init()still loaded remote-connector instruction summaries without a catch, so a 5s snapshot timeout rejectedPromise.alland failed the whole handshake (handleMcpRequest→getServerByName→retryDurableObjectOperation)loadRemoteConnectorInstructionSummariesand omit stalled connectors instead of failing initValidation
npm run validatepassed (format, lint, typecheck, 1282 unit tests, 18 Playwright e2e, 2 MCP e2e, primitives, migrations)Do not merge until CI is green and reviewed.
System recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@49893e20· Head:81982f5fClassification: extends — MCP session init now soft-fails stalled remote-connector snapshot reads used for instruction summaries.
Primitives touched
mcp-serverSystem map
MCP init loads instruction summaries and the capability registry in parallel; only the registry path was fail-soft before this change.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Invariants
Connector snapshot cache keys remain user-scoped; soft-fail omits only the stalled connector's instruction summary and never substitutes another user's connector data.
Summary by CodeRabbit
Bug Fixes
Tests