Fix connect-secret rollback error copy

packages/worker/client/routes/connect-secret-errors.node.test.ts

@@ -0,0 +1,35 @@
+import { expect, test } from 'vitest'
+import { formatConnectorConfigFailureMessage } from './connect-secret-errors.ts'
+
+test('reports rollback when secret rollback completed', () => {
+	const message = formatConnectorConfigFailureMessage(
+		new Error('Config update exploded.'),
+		{ secretRolledBack: true },
+	)
+
+	expect(message).toBe(
+		'Connector configuration failed and the secret was rolled back. Config update exploded.',
+	)
+})
+
+test('does not claim rollback when no connector rollback ran', () => {
+	const message = formatConnectorConfigFailureMessage(
+		new Error('Config update exploded.'),
+		{ secretRolledBack: false },
+	)
+
+	expect(message).toBe(
+		'Connector configuration failed after the secret was saved. Config update exploded.',
+	)
+})
+
+test('reports updated secret retained when connector config fails on existing secret', () => {
+	const message = formatConnectorConfigFailureMessage(
+		new Error('Config update exploded.'),
+		{ secretRolledBack: false, updatedSecretRetained: true },
+	)
+
+	expect(message).toBe(
+		'Connector configuration failed after the secret was updated. Config update exploded.',
+	)
+})

packages/worker/client/routes/connect-secret-errors.ts

@@ -0,0 +1,18 @@
+export function formatConnectorConfigFailureMessage(
+	error: unknown,
+	options: {
+		secretRolledBack: boolean
+		updatedSecretRetained?: boolean
+	},
+) {
+	const message =
+		error instanceof Error
+			? error.message
+			: 'Unable to update connector config.'
+	if (options.updatedSecretRetained) {
+		return `Connector configuration failed after the secret was updated. ${message}`
+	}
+	return options.secretRolledBack
+		? `Connector configuration failed and the secret was rolled back. ${message}`
+		: `Connector configuration failed after the secret was saved. ${message}`
+}