Skip to content

Consolidate low-signal tests from recent feature work - #819

Merged
kody-bot merged 3 commits into
mainfrom
cursor/test-quality-guidelines-3144
Jul 21, 2026
Merged

kody-bot merged 3 commits into
mainfrom
cursor/test-quality-guidelines-3144

Conversation

@cursor

@cursor cursor Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to the last 24h of feature PRs (#802–#817) and yesterday's #801 pass. Trim and merge tests that drifted from the repo's testing principles: fewer longer workflows, no instructional-copy pins, and no sibling micro-cases for the same journey.

Changes

  • Merge document-head cases into one workflow (restore account-route specificity)
  • Drop the onboarding setup-prompt copy-only test; keep origin identification in discovery
  • Fold Stripe createCheckoutSession micro-cases into request/error workflows
  • Consolidate unbound-helper detector shapes; assert hints via parse/structured details
  • Fold package-owner, scope-grant, and delegated package capability siblings into parent workflows
  • Stop pinning advisory lint prose beyond the packageStorage() contract

Validation

  • npx vitest run --project node-unit on the 9 touched node suites (40 tests)
  • npx vitest run --project workers-unit on the 3 touched worker suites (4 tests)

Risk: low — test-only, no production behavior changes.

Open in Web View Automation 
System recap - composes existing primitives (low risk)

Mode: recap | Base: main @ e37819f9 | Head: 33ef3a8a

Classification: composes - test-only consolidation; no production code or
primitive contracts changed.

Primitives touched

Primitive Group Impact
app-ui surfaces composes - document-head / onboarding test workflows only
billing auth composes - stripe-client test consolidation
mcp-server surfaces composes - unbound-hint assertion style
package-runtime runtime composes - unbound-helper detector tests
repo-sessions runtime composes - packageStorage check assertion tighten
saved-packages assistant composes - owner/scope/delegated capability test folds

System map

Test-quality pass over suites added with recent feature work; no runtime path
changes.

Legend: green = composes (wiring only) | amber = extended by this PR | red =
new primitive | gray = context (unchanged, included only when an edge crosses
it).

flowchart LR
	appUi["app-ui<br/>App UI"]:::touched
	billing["billing<br/>Billing"]:::touched
	mcpServer["mcp-server<br/>MCP endpoint"]:::touched
	packageRuntime["package-runtime<br/>Package runtime"]:::touched
	repoSessions["repo-sessions<br/>Repo sessions"]:::touched
	savedPackages["saved-packages<br/>Saved packages"]:::touched
	appUi -->|"document-head + onboarding tests"| appUi
	billing -->|"stripe checkout workflows"| billing
	packageRuntime -->|"unbound-helper detector workflows"| mcpServer
	savedPackages -->|"owner/scope/delegated capability tests"| savedPackages
	repoSessions -->|"packageStorage advisory asserts"| repoSessions
	classDef touched fill:#1a7f37,color:#fff
	classDef extended fill:#9a6700,color:#fff
	classDef added fill:#cf222e,color:#fff
	classDef untouched fill:#57606a,color:#fff
Loading

cursoragent and others added 3 commits July 21, 2026 09:03
Merge fragmented document-head cases into one workflow (restoring
account-route specificity), drop the onboarding setup-prompt copy pin,
and fold createCheckoutSession micro-cases into the stripe client
request/error workflows.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Merge detector shape variants into fewer workflow tests, assert unbound
hints via parse/structured details instead of instructional prose, and
stop pinning advisory lint wording beyond the packageStorage() contract.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Combine package-owner resolution phases, person-scope grant rejection,
and delegated create/get/git-remote coverage into their parent workflow
tests.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kody-bot
kody-bot marked this pull request as ready for review July 21, 2026 09:04
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-819.kody-a99.workers.dev

Worker: kody-pr-819
D1: kody-pr-819-db
KV: kody-pr-819-oauth-kv

Mocks:

@kody-bot
kody-bot merged commit 3999e29 into main Jul 21, 2026
6 checks passed
@kody-bot
kody-bot deleted the cursor/test-quality-guidelines-3144 branch July 21, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants