Consolidate low-signal tests from recent feature work - #819
Merged
Merged
Conversation
Merge fragmented document-head cases into one workflow (restoring account-route specificity), drop the onboarding setup-prompt copy pin, and fold createCheckoutSession micro-cases into the stripe client request/error workflows. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Merge detector shape variants into fewer workflow tests, assert unbound hints via parse/structured details instead of instructional prose, and stop pinning advisory lint wording beyond the packageStorage() contract. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Combine package-owner resolution phases, person-scope grant rejection, and delegated create/get/git-remote coverage into their parent workflow tests. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
July 21, 2026 09:04
Contributor
|
🔎 Preview deployed: https://kody-pr-819.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the last 24h of feature PRs (#802–#817) and yesterday's #801 pass. Trim and merge tests that drifted from the repo's testing principles: fewer longer workflows, no instructional-copy pins, and no sibling micro-cases for the same journey.
Changes
createCheckoutSessionmicro-cases into request/error workflowspackageStorage()contractValidation
npx vitest run --project node-uniton the 9 touched node suites (40 tests)npx vitest run --project workers-uniton the 3 touched worker suites (4 tests)Risk: low — test-only, no production behavior changes.
System recap - composes existing primitives (low risk)
Mode: recap | Base:
main@e37819f9| Head:33ef3a8aClassification: composes - test-only consolidation; no production code or
primitive contracts changed.
Primitives touched
app-uibillingmcp-serverpackage-runtimerepo-sessionssaved-packagesSystem map
Test-quality pass over suites added with recent feature work; no runtime path
changes.
Legend: green = composes (wiring only) | amber = extended by this PR | red =
new primitive | gray = context (unchanged, included only when an edge crosses
it).