Repository navigation
Consolidate low-signal platform feedback tests - #787
Merged
Merged
Conversation
Merge fragmented subscription, queue, service, and schema cases into fewer workflow tests, drop instructional copy pins and a duplicate submitter-identity suite, and assert content warnings via the shared constant. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Contributor
|
🔎 Preview deployed: https://kody-pr-787.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trim and consolidate the platform-feedback test surface added with #783–#785 so it follows the repo’s fewer/longer, behavior-focused testing guidelines.
inputSchemacopy pinssubmitter-identitysuite (covered by admin platform-feedback data)Net: −177 lines across 7 test files. No production code changes.
Test plan
npm run test --targeted platform-feedback + chat node/workers suitesvalidateon the PRSystem recap — composes existing primitives (low risk)
Mode: recap · Base:
main· Head:cursor/test-quality-guidelines-c6feClassification: composes — test-only cleanup; no primitive behavior, schemas, or contracts change.
Primitives touched
platform-feedbackplatform-feedback-dispatch-queuecapability-registrySystem map
Test cleanup only: platform feedback submission/admin paths and the dispatch queue keep the same contracts; this PR only reshapes how those contracts are asserted.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).