Skip to content

Consolidate low-signal platform feedback tests - #787

Merged
kody-bot merged 1 commit into
mainfrom
cursor/test-quality-guidelines-c6fe
Jul 19, 2026
Merged

kody-bot merged 1 commit into
mainfrom
cursor/test-quality-guidelines-c6fe

Conversation

@cursor

@cursor cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Trim and consolidate the platform-feedback test surface added with #783–#785 so it follows the repo’s fewer/longer, behavior-focused testing guidelines.

  • Merge fragmented subscription, queue, service, chat-schema, and workers cases into fewer workflow tests
  • Drop instructional capability description/inputSchema copy pins
  • Delete the duplicate submitter-identity suite (covered by admin platform-feedback data)
  • Assert content warnings via the shared constant instead of hardcoded prose

Net: −177 lines across 7 test files. No production code changes.

Test plan

  • npm run test -- targeted platform-feedback + chat node/workers suites
  • CI validate on the PR
System recap — composes existing primitives (low risk)

Mode: recap · Base: main · Head: cursor/test-quality-guidelines-c6fe

Classification: composes — test-only cleanup; no primitive behavior, schemas, or contracts change.

Primitives touched

Primitive Group Impact
platform-feedback assistant composes — consolidate unit/workers coverage
platform-feedback-dispatch-queue storage composes — merge queue ack/retry workflow tests
capability-registry assistant composes — drop description copy pins in capability tests

System map

Test cleanup only: platform feedback submission/admin paths and the dispatch queue keep the same contracts; this PR only reshapes how those contracts are asserted.

Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).

flowchart LR
	capabilityRegistry["capability-registry<br/>Capability registry"]:::touched
	platformFeedback["platform-feedback<br/>Platform feedback"]:::touched
	dispatchQueue["platform-feedback-dispatch-queue<br/>Platform feedback dispatch queue"]:::touched
	capabilityRegistry -->|"capability tests assert consent/RBAC behavior, not prose"| platformFeedback
	platformFeedback -->|"subscription/service/workers tests merged into workflows"| dispatchQueue
	classDef touched fill:#1a7f37,color:#fff
	classDef extended fill:#9a6700,color:#fff
	classDef added fill:#cf222e,color:#fff
	classDef untouched fill:#57606a,color:#fff
Loading
Open in Web View Automation 

Merge fragmented subscription, queue, service, and schema cases into
fewer workflow tests, drop instructional copy pins and a duplicate
submitter-identity suite, and assert content warnings via the shared
constant.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@cursor
cursor Bot marked this pull request as ready for review July 19, 2026 09:03
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-787.kody-a99.workers.dev

Worker: kody-pr-787
D1: kody-pr-787-db
KV: kody-pr-787-oauth-kv

Mocks:

@kody-bot
kody-bot merged commit 6242566 into main Jul 19, 2026
6 checks passed
@kody-bot
kody-bot deleted the cursor/test-quality-guidelines-c6fe branch July 19, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants