docs: drop temporal framing in email verification success copy - #736
Merged
Merged
Conversation
Rewrite 'MCP access is now available' to present-tense wording after email verification, matching the documentation principle that user-facing copy should describe how things work today rather than narrating a rollout. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Resolve conflicts after main consolidated redirect helper tests into safe-redirect.node.test.ts and relaxed handler message assertions.
Restore 'MCP access is now available' in email verification success messages and add a source comment explaining why this user-facing copy intentionally uses temporal wording after a state transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated documentation wording sweep found one non-exempt changelog-style phrase introduced by recent email verification work (#734).
Changes
safe-redirect.ts.Rationale
Per
docs/contributing/documentation.md, user-visible copy should describe how things work today rather than narrating a rollout ("now available" implies a recent change).Verification
npm run formatnpx nx run worker:test -- packages/worker/src/app/email-verification.node.test.ts packages/worker/src/app/handlers/verify-email.node.test.ts packages/worker/client/routes/pending-verification-path.node.test.tsNote
Low Risk
User-facing copy commentary and an E2E assertion only; no auth, redirect, or MCP gating logic changes in the diff.
Overview
Documents an intentional wording exception in
resolveVerifyEmailSuccessCta(safe-redirect.ts): post-verification success text may keep “MCP access is now available” because it describes the moment access unlocks, with a pointer todocs/contributing/documentation.md.E2E coverage in
invite-signup-verification.spec.tsnow expects that success message after the OAuth resume verify-email flow, alongside the existing “Continue authorization” checks.Reviewed by Cursor Bugbot for commit 2334954. Bugbot is set up for automated code reviews on this repo. Configure here.