Consolidate email verification tests and de-pin instructional copy - #735
Merged
Merged
Conversation
Merge five fragmented client redirect helper tests into one workflow file, move safe-redirect coverage to a dedicated module test, and assert href/label contracts instead of pinning success-message prose. Trim the verify-email handler test and E2E invite flow accordingly. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Contributor
|
🔎 Preview deployed: https://kody-pr-735.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up test-quality pass on the email verification work merged in #734. The new tests were fragmented across many small files and pinned instructional success-message copy.
Changes
email-verification-flow.node.test.tssafe-redirect.node.test.tsfor redirect normalization and CTA contracts (href/label, not prose)email-verification.node.test.tsto URL-building behavior onlyNet −73 lines while keeping the same behavioral coverage.