Repository navigation
Fix overlapping OAuth provider detail URLs - #696
Conversation
Allow long authorize/token URLs to wrap inside the shared detail grid so columns no longer overflow into each other on the connect OAuth page.
📝 WalkthroughWalkthroughIntegration detail styles now constrain and wrap long values consistently. Account integration and OAuth detail views use the shared value styling for displayed URLs, secrets, metadata, and other integration fields. ChangesIntegration detail layout
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-696.kody-a99.workers.dev Worker: Mocks:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/worker/client/styles/style-primitives.ts (1)
231-237: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
wordBreak: 'break-all'is redundant and degrades non-URL text wrapping.
overflowWrap: 'anywhere'already handles long unbreakable strings (URLs) by breaking mid-word only when the content would overflow. AddingwordBreak: 'break-all'forces breaking at every character boundary regardless of available space, which causes mid-word breaks in multi-word values like scopes ("chat:write channels:read") even when breaking at spaces would suffice. SincedetailValueCssis now shared across all detail values (URLs, scopes, timestamps, flow names), removingwordBreakimproves wrapping for non-URL text without affecting URL behavior.♻️ Proposed fix
export const detailValueCss = { display: 'block', maxWidth: '100%', minWidth: 0, color: colors.text, overflowWrap: 'anywhere', whiteSpace: 'normal', - wordBreak: 'break-all', }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/worker/client/styles/style-primitives.ts` around lines 231 - 237, Remove the wordBreak: 'break-all' declaration from detailValueCss, while retaining overflowWrap: 'anywhere' so long unbreakable values still wrap without forcing unnecessary mid-word breaks in scopes, timestamps, and other detail values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/worker/client/styles/style-primitives.ts`:
- Around line 231-237: Remove the wordBreak: 'break-all' declaration from
detailValueCss, while retaining overflowWrap: 'anywhere' so long unbreakable
values still wrap without forcing unnecessary mid-word breaks in scopes,
timestamps, and other detail values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9244dcef-6afd-46b4-a73f-da790ed07074
📒 Files selected for processing (3)
packages/worker/client/routes/account-integrations.tsxpackages/worker/client/routes/connect-oauth.tsxpackages/worker/client/styles/style-primitives.ts
Drop word-break: break-all so multi-word detail values can wrap at spaces while long URLs still break via overflow-wrap: anywhere.
Long authorize/token URLs in the Provider details grid were overflowing into neighboring columns on
/connect/oauth.Changes
detailItemCss/detailValueCssto constrain width and wrap unbroken strings (min-width: 0,overflow-wrap: anywhere).detailValueCssto bare<code>URL/name fields on the connect OAuth page.word-break: break-allso multi-word values can wrap at spaces.Verification
System recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@5fe4a1cd· Head: latest on branchClassification: extends — shared UI detail styles now wrap long values so grid columns stay in bounds.
Primitives touched
app-uiSystem map
Risk callouts
Summary by CodeRabbit