Skip to content

fix: stop invalid preview workflow validation #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 2 commits into from
Apr 10, 2026
Merged

fix: stop invalid preview workflow validation #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a877f81
fix: stop invalid preview workflow validation
cursoragent Apr 10, 2026
39c0569
fix: gate preview cleanup token safely
cursoragent Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ on:
permissions:
contents: read
pull-requests: write
environments: write

concurrency:
group: >-
Expand Down Expand Up @@ -455,6 +454,9 @@ jobs:
github.event.pull_request.head.repo.fork == false) ||
(github.event_name == 'workflow_dispatch' &&
inputs.action == 'cleanup')
env:
PREVIEW_ENVIRONMENT_GITHUB_TOKEN:
${{ secrets.PREVIEW_ENVIRONMENT_GITHUB_TOKEN }}
steps:
- name: 📦 Checkout
uses: actions/checkout@v6.0.2
Expand Down Expand Up @@ -569,15 +571,26 @@ jobs:
set -euo pipefail
node tools/ci/preview-resources.ts cleanup --worker-name "$APP_WORKER_NAME"

- name: ℹ️ Skip GitHub preview environment delete
if: >-
always() &&
env.PREVIEW_ENVIRONMENT_GITHUB_TOKEN == ''
run: >
echo "Skipping GitHub preview environment delete;
PREVIEW_ENVIRONMENT_GITHUB_TOKEN is not configured."

- name: 🏷️ Delete GitHub preview environment
if: always()
if: >-
always() &&
env.PREVIEW_ENVIRONMENT_GITHUB_TOKEN != ''
uses: actions/github-script@v8.0.0
env:
EVENT_NAME: ${{ github.event_name }}
PR_NUMBER: ${{ github.event.pull_request.number || '' }}
INPUT_TARGET: ${{ inputs.target }}
INPUT_PR_NUMBER: ${{ inputs.pr_number }}
with:
github-token: ${{ env.PREVIEW_ENVIRONMENT_GITHUB_TOKEN }}
script: |
const eventName = process.env.EVENT_NAME;
let envName;
Expand Down
Loading