Lead onboarding step 3 with built-in integration cards - #1349
Merged
Merged
Conversation
Swap the emphasis: built-in integrations are the path of least
resistance, so they now render as the step's primary card grid (top
six by use, up from three) with provider logos, while starter packages
demote to a compact list under a 'Starter packages / Advanced' label.
The step retitles from 'Install a starter package' to 'Connect your
tools'. Deployments with no enabled built-ins keep the original
package-card layout.
Also rewords the built-ins doc line that tripped the docs
temporal-language check ('no longer use' reads as rollout language to
the checker).
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe onboarding wizard now focuses step 3 on connecting tools. It displays built-in integrations first, supports up to six providers, and moves starter packages into compact Advanced rows when integrations are available. ChangesOnboarding tool connections
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Onboarding
participant onboarding handler
participant OAuth route
Onboarding->>onboarding handler: load up to six built-in providers
onboarding handler-->>Onboarding: return provider configurations
Onboarding->>OAuth route: open provider connection route
OAuth route-->>Onboarding: return OAuth connection flow
Onboarding->>Onboarding: render starter packages in Advanced rows
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
🔎 Preview deployed: https://kody-pr-1349.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Swaps the emphasis in onboarding step 3 so the path of least resistance reads first:
ProviderIconset), the label, and a "Connect" pill linking to/connect/oauth?provider={slug}. The "Bring your own OAuth app" line sits under the grid.OnboardingStarterCardandOnboardingDiyCardgain arowvariant (icon + text left, Install/Copy action right, status wrapping beneath) that reuses all the existing install/copy logic and test ids.Testing
npm run validategreen (also fixed a docs temporal-language check hit: the built-ins doc line from Make agent-action liability abundantly clear #1348 said "no longer use", which the checker reads as rollout language; reworded to "unused ones").Summary by CodeRabbit
New Features
Documentation