Make account Activity usable on narrow viewports - #1265
Conversation
Stack the shared list/detail layout at the account-nav breakpoint, put the selected run first on phones, wrap long ids, and keep logs/metadata from overflowing the pane. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe account management and account activity layouts now share 860px and 1100px responsive breakpoints. Selected activity details can appear before navigation, filters stack vertically, and long content wraps without overflowing. ChangesAccount activity responsive layout
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-1265.kody-a99.workers.dev Worker: Mocks:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/worker/client/routes/account-activity.tsx`:
- Around line 778-784: Update the detail content rendered within the section
using cardCss so direct children such as AccountManagementMessage can shrink and
wrap unbreakable error text: add minWidth: 0 and overflowWrap: 'anywhere' to the
relevant detail wrapper or text element, or limit overflow: 'hidden' to the log
and metadata scroll containers instead.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 687b7818-0910-4dc8-af70-5efd4197467e
📒 Files selected for processing (2)
packages/worker/client/routes/account-activity.tsxpackages/worker/client/routes/account-management-components.tsx
Keep the selected-run card from hiding long error text on narrow screens. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Keep Activity (and other list/detail pages) single-column until 1100px so a still-visible 200px account rail cannot squeeze logs into a few pixels. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Intent
Make
/account/activityreadable and usable on phones and other narrow viewports instead of forcing a crushed two-column layout.Summary
1100px, so the still-visible 200px account rail cannot squeeze the detail pane.860px.Testing
System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@d142d133· Head:328bace4Classification: composes — no primitives added or changed; this PR restyles the existing account list/detail layout for narrow viewports.
Primitives touched
app-uiSystem map
Account Activity still uses the same run-record UI; the layout stacks and wraps before two content columns can crush.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Summary by CodeRabbit