Skip to content

Make account Activity usable on narrow viewports - #1265

Merged
kody-bot merged 3 commits into
mainfrom
cursor/activity-narrow-viewport-2541
Aug 7, 2026
Merged

kody-bot merged 3 commits into
mainfrom
cursor/activity-narrow-viewport-2541

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Aug 7, 2026 •

Copy link
Copy Markdown
Owner

Intent

Make /account/activity readable and usable on phones and other narrow viewports instead of forcing a crushed two-column layout.

Summary

  • Shared account list/detail layout stacks until 1100px, so the still-visible 200px account rail cannot squeeze the detail pane.
  • Account nav still collapses at 860px.
  • When a run is selected, the detail pane moves above the list on stacked screens.
  • Long ids wrap, metadata goes single-column earlier, and logs stay readable.

Testing

  • Playwright screenshots at exact CSS widths 390, 700, 960 (stacked, detail first) and 1200 (two-column).
  • CI Validate / Preview on this PR.
System recap — composes existing primitives (low risk)

Mode: recap · Base: main @ d142d133 · Head: 328bace4

Classification: composes — no primitives added or changed; this PR restyles the existing account list/detail layout for narrow viewports.

Primitives touched

Primitive Group Impact
app-ui surfaces composes — account list/detail stacking and Activity wrapping

System map

Account Activity still uses the same run-record UI; the layout stacks and wraps before two content columns can crush.

Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).

flowchart LR
	appUi["app-ui<br/>Browser app"]:::touched
	appUi -->|"stack list/detail below 1100px"| appUi
	classDef touched fill:#1a7f37,color:#fff
	classDef extended fill:#9a6700,color:#fff
	classDef added fill:#cf222e,color:#fff
	classDef untouched fill:#57606a,color:#fff
Loading
Open in Web Open in Cursor 

Summary by CodeRabbit

  • UI Improvements
    • Improved account activity and account management layouts on narrow screens.
    • Detail content can now appear before sidebar navigation on smaller displays.
    • Filter controls stack vertically for easier mobile use.
    • Prevented detail cards and metadata from overflowing.
    • Improved wrapping and column handling for long values, code, and activity logs.
    • Enhanced readability and navigation across mobile and smaller displays.

Stack the shared list/detail layout at the account-nav breakpoint, put
the selected run first on phones, wrap long ids, and keep logs/metadata
from overflowing the pane.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 84298873-c5d8-4df5-a019-3ade452b98ac

📥 Commits

Reviewing files that changed from the base of the PR and between 81c194b and 328bace.

📒 Files selected for processing (1)
  • packages/worker/client/routes/account-management-components.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/worker/client/routes/account-management-components.tsx

📝 Walkthrough

Walkthrough

The account management and account activity layouts now share 860px and 1100px responsive breakpoints. Selected activity details can appear before navigation, filters stack vertically, and long content wraps without overflowing.

Changes

Account activity responsive layout

Layer / File(s) Summary
Shared narrow-screen layout foundation
packages/worker/client/routes/account-management-components.tsx
Exports shared navigation and stacking breakpoints, adds optional detail-first ordering, and constrains long metadata values.
Account activity narrow-screen behavior
packages/worker/client/routes/account-activity.tsx
Prioritizes selected details, stacks filters, constrains detail cards, collapses log rows, and wraps metadata content at narrow widths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • kentcdodds/kody#1233: Extends responsive layout and metadata behavior in the same account activity and account management files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: improving Account Activity usability on narrow viewports.
Description check ✅ Passed The description includes the required Intent, Summary, and Testing sections and explains the responsive layout changes and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/activity-narrow-viewport-2541

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kody-bot
kody-bot marked this pull request as ready for review August 7, 2026 00:08
@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-1265.kody-a99.workers.dev

Worker: kody-pr-1265
D1: kody-pr-1265-db
KV: kody-pr-1265-oauth-kv

Mocks:

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/worker/client/routes/account-activity.tsx`:
- Around line 778-784: Update the detail content rendered within the section
using cardCss so direct children such as AccountManagementMessage can shrink and
wrap unbreakable error text: add minWidth: 0 and overflowWrap: 'anywhere' to the
relevant detail wrapper or text element, or limit overflow: 'hidden' to the log
and metadata scroll containers instead.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 687b7818-0910-4dc8-af70-5efd4197467e

📥 Commits

Reviewing files that changed from the base of the PR and between d142d13 and 0c63a23.

📒 Files selected for processing (2)
  • packages/worker/client/routes/account-activity.tsx
  • packages/worker/client/routes/account-management-components.tsx

Comment thread packages/worker/client/routes/account-activity.tsx
cursoragent and others added 2 commits August 7, 2026 00:34
Keep the selected-run card from hiding long error text on narrow screens.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Keep Activity (and other list/detail pages) single-column until 1100px so
a still-visible 200px account rail cannot squeeze logs into a few pixels.

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kody-bot
kody-bot merged commit 25c879f into main Aug 7, 2026
11 of 16 checks passed
@kody-bot
kody-bot deleted the cursor/activity-narrow-viewport-2541 branch August 7, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants