Skip to content

docs: close out the UserMeter expand-phase language - #1212

Merged
kentcdodds merged 2 commits into
mainfrom
cursor/expand-phase-docs-0671
Aug 4, 2026
Merged

kentcdodds merged 2 commits into
mainfrom
cursor/expand-phase-docs-0671

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Aug 4, 2026 •

Copy link
Copy Markdown
Owner

Intent

Final docs pass for the post-cutover contract program: the storage, package-service, write-lease, and daily-counter contracts are all complete, so the architecture docs should stop describing UserMeter as mid-expand.

Summary

  • Retitle ## UserMeter (expand phase) to ## UserMeter and update all nine #usermeter-expand-phase anchors across entitlements.md and data-storage.md
  • Fix the stale write-fencing anchor that still pointed at the pre-contract heading
  • Rewrite the Vectorize migration note that described a pending "remove the default-namespace read" contract step — search paths are namespaced-only in code today

Testing

  • npm run docs:check-temporal green; format green; docs-only change (CI Validate covers the rest)

System recap

SYSTEM RECAP
mode: recap
overall: composes
risk: Low (docs only)
paths:
  - docs/contributing/architecture/entitlements.md
  - docs/contributing/architecture/data-storage.md

Conductor report

STATUS: ready pending CI. Last wave of the cleanup program.

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Documentation
    • Updated storage documentation links to use the current UserMeter reference.
    • Clarified that namespaced Vectorize search is active and no longer uses the default namespace.
    • Updated entitlement documentation links to reference the renamed UserMeter section.

@kentcdodds
kentcdodds marked this pull request as ready for review August 4, 2026 07:23
@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cbfec7aa-a92f-4fa4-a95a-0168d8ea0401

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf22d1 and 7542b1f.

📒 Files selected for processing (1)
  • docs/contributing/architecture/data-storage.md
📝 Walkthrough

Walkthrough

Updated architecture documentation links to the current UserMeter section and changed Vectorize migration text to describe active namespaced search.

Changes

Architecture documentation

Layer / File(s) Summary
Update UserMeter references
docs/contributing/architecture/data-storage.md, docs/contributing/architecture/entitlements.md
Replaced retired UserMeter anchors with the current #usermeter reference.
Document Vectorize namespace state
docs/contributing/architecture/data-storage.md
Documented that search uses per-account namespaces and the reserved builtin namespace, with vectors derived from D1.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • kentcdodds/kody#1133: Updates the same architecture documentation for UserMeter migration and legacy D1 counter removal.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change to close out UserMeter expand-phase language.
Description check ✅ Passed The description includes intent, summary, testing, and system-risk information that matches the documentation-only changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/expand-phase-docs-0671

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/contributing/architecture/data-storage.md`:
- Around line 1442-1444: Update the earlier paragraph near the legacy namespace
discussion to describe default-namespace access only as historical migration
behavior, or remove that claim entirely. Keep the current query contract
unambiguously limited to per-account namespaces plus the reserved builtin
namespace, while preserving the requirement that each signed-in user has fully
isolated assistant resources.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae0231a5-0cb4-4bd4-ab50-562e3065bab6

📥 Commits

Reviewing files that changed from the base of the PR and between 20544a9 and 2369025.

📒 Files selected for processing (2)
  • docs/contributing/architecture/data-storage.md
  • docs/contributing/architecture/entitlements.md

Comment thread docs/contributing/architecture/data-storage.md
The storage, package-service, write-lease, and daily-counter contracts are
complete, so retitle "UserMeter (expand phase)" to "UserMeter", fix the stale
write-fencing anchor, and update the Vectorize note that still described a
pending default-namespace contract read (search is namespaced-only).
@cursor
cursor Bot force-pushed the cursor/expand-phase-docs-0671 branch from 2369025 to 2cf22d1 Compare August 4, 2026 07:32
@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-1212.kody-a99.workers.dev

Worker: kody-pr-1212
D1: kody-pr-1212-db
KV: kody-pr-1212-oauth-kv

Mocks:

@kentcdodds
kentcdodds merged commit fdbfbf4 into main Aug 4, 2026
9 checks passed
@kentcdodds
kentcdodds deleted the cursor/expand-phase-docs-0671 branch August 4, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants