Expose RunLog seed failure stages - #1200
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe legacy seed flow now classifies per-user failures by inventory surface and phase. Results expose nullable failure metadata. Processing isolates failed users, avoids raw error logging, and documents the fields in the MCP capability schema. ChangesLegacy seed diagnostics
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant AdminRunLog
participant processUser
participant runSurfaceStep
participant TrackingRPC
AdminRunLog->>processUser: process one user
processUser->>runSurfaceStep: run workflow, job, or activation step
runSurfaceStep->>TrackingRPC: read, seed, or verify inventory
TrackingRPC-->>runSurfaceStep: success or error
runSurfaceStep-->>processUser: classified result
processUser-->>AdminRunLog: user result with failureStage and failurePhase
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
🔎 Preview deployed: https://kody-pr-1200.kody-a99.workers.dev Worker: Mocks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Diagnose the one remaining production RunLog seed failure without exposing user-authored data.
Summary
failureStageandfailurePhasefields to admin seed resultsTesting
System changes
No seeding semantics change; operator diagnostics only.
Conductor report
STATUS: in-progress
What shipped: content-free seed failure staging is pushed; CI/merge/deploy and production rerun pending.
Risk self-assessment: low — additive admin output fields and safer logs.
Merged/deployed: no / no.
Scope spill: none.
Summary by CodeRabbit