Skip to content

Conversation

@kentcdodds
Copy link
Owner

What: feat: support custom node version based on engines (falls back to node version 8).

Why: So projects can more easily specifically target the version they need to support.

How: Using semver and getting the engines.node property in the package.json to determine the oldest version supported and transpile down to that.

Checklist:

  • Documentation N/A 😅
  • Tests N/A 😅
  • Ready to be merged
  • Added myself to contributors table N/A

@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #66 into master will decrease coverage by 0.71%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage    72.6%   71.89%   -0.72%     
==========================================
  Files          21       21              
  Lines         365      370       +5     
  Branches       81       82       +1     
==========================================
+ Hits          265      266       +1     
- Misses         79       82       +3     
- Partials       21       22       +1
Impacted Files Coverage Δ
src/config/babelrc.js 77.77% <33.33%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f916e8...fde3521. Read the comment docs.

@kentcdodds kentcdodds merged commit 3178358 into master Sep 4, 2018
@kentcdodds kentcdodds deleted the pr/custom-node-version branch September 4, 2018 16:48
@kentcdodds
Copy link
Owner Author

🎉 This PR is included in version 0.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants