Skip to content

fix: create definition files into provided folder #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 3 commits into from
Dec 7, 2020
Merged

fix: create definition files into provided folder #182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
394a4fa
fix: create definition files into provided folder
marcosvega91 Dec 7, 2020
a8f4f79
fix(babel): pass destination folder from babel
marcosvega91 Dec 7, 2020
f70fb7e
test: check if folder is used correctly
marcosvega91 Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scripts/build/rollup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function go() {

if (hasTypescript && !args.includes('--no-ts-defs')) {
console.log('Generating TypeScript definitions')
result = generateTypeDefs()
result = generateTypeDefs(fromRoot('dist'))
if (result.status !== 0) return result.status

for (const format of formats) {
Expand Down
4 changes: 2 additions & 2 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ function hasLocalConfig(moduleName, searchOptions = {}) {
return result !== null
}

function generateTypeDefs() {
function generateTypeDefs(outputDir) {
return spawn.sync(
resolveBin('typescript', {executable: 'tsc'}),
// prettier-ignore
[
'--declaration',
'--emitDeclarationOnly',
'--noEmit', 'false',
'--outDir', fromRoot('dist'),
'--outDir', outputDir,
],
{stdio: 'inherit'},
)
Expand Down