fix: use jsdom jest environment and h jsx pragma for preact #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 18 18
Lines 334 334
Branches 79 79
=======================================
Hits 290 290
Misses 36 36
Partials 8 8
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Jun 7, 2020
kentcdodds
reviewed
Jun 8, 2020
Owner
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Almost there! Thanks for your patience!
Owner
|
Thanks! |
Owner
|
@all-contributors please add @mihar-22 for code |
Contributor
|
I've put up a pull request to add @mihar-22! 🎉 |
Owner
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the build tools for
@testing-library/preacttokcd-scriptsfor consistency among other testing library packages but I encountered some linting + testing issues. I think these should fix it. I tried testing locally vianpm linkbut I was getting an error (Environment key "jest/globals" is unknown) fromesling-config-kentcdoddsand some strange modules missing errors that may be related tonpm link.Ref: testing-library/preact-testing-library#24