Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 24, 2020

Closes #145

@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files          18       18           
  Lines         335      335           
  Branches       80       80           
=======================================
  Hits          291      291           
  Misses         36       36           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bf8b4...84947cf. Read the comment docs.

@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch from 03a4cb5 to 84947cf Compare May 24, 2020 10:36
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

"@rollup/plugin-json": "^4.0.3",
"@rollup/plugin-node-resolve": "^8.0.0",
"@rollup/plugin-replace": "^2.3.2",
"@types/jest": "^25.2.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good idea!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had removed it, since jest now has its own types, but seems like that caused #145 😓

"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-size-snapshot": "^0.11.0",
"rollup-plugin-terser": "^5.3.0",
"rollup-plugin-size-snapshot": "^0.12.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda want to remove this feature in the next major version we need to make.

@kentcdodds kentcdodds merged commit 14b6682 into kentcdodds:master May 25, 2020
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6.1.0 seems to have a regression

2 participants