Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

All rollup plugins only support [email protected]

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          18       18           
  Lines         332      332           
  Branches       78       78           
=======================================
  Hits          291      291           
  Misses         34       34           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5049ec...576de83. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.... Well all I can tell you is that I tried it and it seems to work on React Testing Library 🤔

@MichaelDeBoey
Copy link
Contributor Author

Seems like the official plugins have updated their peerDependency
Will create a, upstream PR for rollup-plugin-size-snapshot, so that one won't throw errors anymore

@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch May 1, 2020 12:22
@kentcdodds
Copy link
Owner

I'm thinking about removing that dependency actually. I don't use the feature anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants