Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

BREAKING CHANGE: Formatting changed due to major Prettier update

I've changed Prettier's arrowParens to always as that's the recommended way from now on.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #127 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          18       18           
  Lines         325      325           
  Branches       75       75           
=======================================
  Hits          284      284           
  Misses         34       34           
  Partials        7        7           
Impacted Files Coverage Δ
src/index.js 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd19fa...49ed148. Read the comment docs.

BREAKING CHANGE: Formatting changed due to major Prettier update
@kentcdodds
Copy link
Owner

I disagree with the recommendation. I'll not be changing that config value.

@MichaelDeBoey
Copy link
Contributor Author

I'll revert the option again 🙂

@MichaelDeBoey
Copy link
Contributor Author

@kentcdodds Reverted the arrowParens option 🙂

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@kentcdodds kentcdodds merged commit aa634cd into kentcdodds:master Mar 22, 2020
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants