Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to suppress tabs from certain divisions #223

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

therealzanfar
Copy link
Contributor

In the use-case that prompted this feature, I needed divided bins, but the contents were only differentiated by color--not something that needs to be on a label as it's evident. In this case, the "extra" labels over the other divisions looked out-of-place, or like I hadn't added labels yet.

This feature allows the option to only place label tabs on some divisions. Currently, the options support the default behavior, and suppressing all but the upper-left tab, but the code should be relatively easy to extend. I can see a useful options for each corner, and maybe each side (just top row, just left row, etc), but I don't want to clutter the code unless they are needed.

@therealzanfar
Copy link
Contributor Author

Example render:

gridfinity-rebuilt-bins-suppressed-tabs

Copy link
Collaborator

@EmperorArthur EmperorArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems with this functionality, and can understand not using a boolean. Since it allows for expansion later on.

Just a minor tweak that I can't make myself and this will be ready to merge.

gridfinity-rebuilt-utility.scad Show resolved Hide resolved
Copy link
Collaborator

@EmperorArthur EmperorArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work.

gridfinity-rebuilt-utility.scad Show resolved Hide resolved
@EmperorArthur
Copy link
Collaborator

Merging, since pre-commit failure is due to a change in Ubuntu.

@EmperorArthur EmperorArthur merged commit b4ff706 into kennetek:main Oct 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants