feat: support crosshair base for single magnet #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimlie
commented
Jul 28, 2024
| @@ -48,12 +48,15 @@ fity = 0; // [-1:0.1:1] | |||
| /* [Styles] */ | |||
|
|
|||
| // baseplate styles | |||
| style_plate = 0; // [0: thin, 1:weighted, 2:skeletonized, 3: screw together, 4: screw together minimal] | |||
| style_plate = 0; // [0: thin, 1:weighted, 2:skeletonized, 3: screw together, 4: screw together minimal, 5:crosshair, 6:screw together crosshair] | |||
There was a problem hiding this comment.
I feel that screw together should be a separate feature, also because I would like to use S-04-02 magnets instead of screws :)
There was a problem hiding this comment.
I agree, as screw together can be combined with multiple style plates.
| @@ -157,13 +162,6 @@ module cutter_weight() { | |||
| } | |||
| } | |||
| } | |||
| module hole_pattern(){ | |||
There was a problem hiding this comment.
I made hole_pattern a utilility so it's moved to the utiliy.scad. The hole-pattern util is also used by bins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for bases with a single hole/magnet as a single N45 S-06-02-N magnet should be strong enough in most (of my) cases.
The spoke width is a parameter, but the default value of 3 seems as sturdy as the skeletonized variant and uses pretty much the same amount of filament.