Fix Baseplate Not Rendering & Generate Baseplate From Profile #187
Conversation
Everything now goes through block_base_hole(...) Noting in gridfinity-rebuilt-utility knows or cares what sytle_hole contains.
Similar to ljbeal's Pull Request. However, the implementation is completely different. kennetek#144
Makes holes print better. Use Affine Translation Matrices to be clear how everything works without being too verbose.
Does not include all combinations.
Helps prevent / minimize issues with filament droop.
Expecially when Cura decides to start the top of hole in mid-air.
Visible Changes:
* Supportless screw holes have a 3rd layer.
* Supportless magnet holes without screw holes have a 3rd layer.
Backend Changes:
* Switched to a completely different generation strategy.
* Previous strategy directly produced negative.
* New strategy is to make a positive,
then use that to create a negative.
* Algorithm for multiple layers is not perfect,
but works within tollerances set.
* These are not (yet) triggered/run by the CI/CD system.
Used to ensure all hole options work.
May want to consider auto-generating these as part of the documentation build.
* Updated constant names to match previous changes.
This can be re-used for the baseplate.
Difference was small enough the slicer mostly ignored it.
Hole changes were not tested against it. Many oppertunities for improvements here.
Also fixes tests.
As opposed to being a parameter of `create_image`. Also made CameraArguments support fluent.
It now also supports all the hole options. Note: Tests are not performed, due to the high rendering time.
Simplified profile_skeleton() by using `offset` instead of `minovsky`. This is much less computationally expensive, and easier to understand.
* Now behaves more like rounded_rectangle, but creates 2d or 3d items. * Deprecated rounded_rectangle. * Added significant input checks to ensure values are valid.
The default for square is center=false.
Previous implementation was off by 0.5mm, and required creating a gridfinity base. This is much more flexible, and easier to understand.
|
Pictures from Edit: How do I make these smaller?!? Also tests are not comprehensive, and do not cover other modes. The gaps are a rendering issue and are not there when creating the final model.
|
|
I tried out this PR for my first Gridfinity baseplate. It worked great. I quite like the crush ribs for keeping magnets in place. Thanks for pulling this together. |
There was a problem hiding this comment.
Fit to drawer functionality has been lost.
The PR uses more modular construction (square_baseplate_lip, solid_square_baseplate, square_baseplate_corner), which appears to focus more on the modular and customizable aspect rather than ensuring the "fit to drawer" functionality.
No tests added yet.
Fit to drawer functionality has been restored, though tests were not added. Please re-examine. |
Thanks! Whenever you're ready feel free to merge it, as I don't have permissions to do so. |
|
@EmperorArthur : Thanks for your bugfix. I'm using your branch as a second remote origin and it solves #202 perfectly for me. |
EmperorArthur
requested review from
Ruudjhuu,
kennetek and
ndemarco
and removed request for
ndemarco
|
Tried manually merging this, but "main" is a protected branch, and requires one reviewer to approve. |
|
Works as intended.
|
Incorporates #179
Main Changes
First, this fixes the baseplate not correctly in OpenSCAD version 2024.02.16 (git 55be9cf86). Done by switching from
minovskytooffsetin one function.Second, instead of using a negative of the bin's this creates the base plate using technical data from the spec.
Other changes
Deprecated
rounded_rectanglein favor of a newrounded_squarefunction. Which operates like the built insquareandcubefunctions.Opinion
The
minovskyfunction just seems to cause more issues than it is worth.