Merge pull request openflagr#6 from kenli-rubrik/master

Make query batch use post with body instead of array query params
kenli-rubrik · Jun 22, 2018 · 9204096 · 9204096
2 parents 026f52d + ad82c0e
commit 9204096
Show file tree

Hide file tree

Showing 8 changed files with 87 additions and 117 deletions.
diff --git a/docs/api_docs/bundle.yaml b/docs/api_docs/bundle.yaml
@@ -733,19 +733,21 @@ paths:
           schema:
             $ref: '#/definitions/error'
   /query/batch:
-    get:
+    post:
       tags:
         - query
       operationId: getFlagByNameBatch
       parameters:
-        - in: query
-          name: flagNames
+        - in: body
+          name: body
           required: true
-          type: array
-          items:
-            type: string
-            minLength: 1
-          minItems: 1
+          description: query batch request
+          schema:
+            type: array
+            items:
+              type: string
+              minLength: 1
+            minItems: 1
       responses:
         '200':
           description: >-

diff --git a/pkg/handler/query.go b/pkg/handler/query.go
@@ -42,7 +42,7 @@ func (qAPI *queryAPI) GetFlagByName(params query.GetFlagByNameParams) middleware
 }
 
 func (qAPI *queryAPI) GetFlagByNameBatch(params query.GetFlagByNameBatchParams) middleware.Responder {
-	flagNames := params.FlagNames
+	flagNames := params.Body
 
 	fs := []entity.Flag{}
 	q := entity.NewFlagQuerySet(getDB())

diff --git a/swagger/query_batch.yaml b/swagger/query_batch.yaml
@@ -1,16 +1,18 @@
-get:
+post:
   tags:
     - query
   operationId: getFlagByNameBatch
   parameters:
-    - in: query
-      name: flagNames
+    - in: body
+      name: body
       required: true
-      type: array
-      items:
-        type: string
-        minLength: 1
-      minItems: 1
+      description: query batch request
+      schema:
+        type: array
+        items:
+          type: string
+          minLength: 1
+        minItems: 1
   responses:
     200:
       description: returns list of flags with the given names. Omits flags who's names weren't found.

diff --git a/swagger_gen/restapi/embedded_spec.go b/swagger_gen/restapi/embedded_spec.go
diff --git a/swagger_gen/restapi/operations/flagr_api.go b/swagger_gen/restapi/operations/flagr_api.go
diff --git a/swagger_gen/restapi/operations/query/get_flag_by_name_batch.go b/swagger_gen/restapi/operations/query/get_flag_by_name_batch.go
diff --git a/swagger_gen/restapi/operations/query/get_flag_by_name_batch_parameters.go b/swagger_gen/restapi/operations/query/get_flag_by_name_batch_parameters.go
diff --git a/swagger_gen/restapi/operations/query/get_flag_by_name_batch_urlbuilder.go b/swagger_gen/restapi/operations/query/get_flag_by_name_batch_urlbuilder.go