Skip to content

Bump xunit.runner.visualstudio from 2.8.2 to 4.0.0 - #704

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/tests/Diariz.Api.IntegrationTests/multi-7935eea600
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/tests/Diariz.Api.IntegrationTests/multi-7935eea600

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Updated xunit.runner.visualstudio from 2.8.2 to 4.0.0.

Release notes

Sourced from xunit.runner.visualstudio's releases.

4.0.0

Release notes: https://xunit.net/releases/visualstudio/4.0.0

4.0.0-pre.5

Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.5

4.0.0-pre.4

Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.4

4.0.0-pre.3

Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.3

3.1.5

Release notes: https://xunit.net/releases/visualstudio/3.1.5

Commits viewable in compare view.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: xunit.runner.visualstudio
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Sep 1, 2026
@dependabot
dependabot Bot requested a review from kenhayward as a code owner September 1, 2026 11:50
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Sep 1, 2026
@kenhayward

Copy link
Copy Markdown
Owner

Closing: this bump reproducibly breaks the integration suite.

There are three PRs for the same upgrade, scoped differently - #704 (both test projects), #706
(IntegrationTests only) and #707 (Tests only). #704 and #706 are independent branches, and both
fail .NET integration (Testcontainers) on the same two tests:

VectorIndexIntegrationTests.UnfencedSemanticSql_CanPlanOntoTheAnnIndex                    [FAIL]
VectorIndexIntegrationTests.UnfencedSemanticSql_ReturnsTheSameNeighbours_AsTheExactScan   [FAIL]
Failed: 2, Passed: 496

with expected an ordered scan of IX_TranscriptChunks_Embedding; the plan was: ... Sort.

Every other open dependency PR is green on that job, including #700, which moved 14 NuGet packages
across four projects and all four lock files.

This is not a framework incompatibility: xunit.runner.visualstudio 4.0.0 still advertises support
for xunit v1, v2 and v3, so it is compatible with xunit 2.9.x in principle. The likelier cause is that
the runner major changes test discovery order or parallelism, and those two tests assert on a Postgres
query plan - which depends on how many rows earlier tests have left in the shared Testcontainers
database.

So the underlying fragility is arguably in the tests rather than in the package. Until that is fixed,
merging this would turn main red, so it is closed rather than held.

@kenhayward kenhayward closed this Sep 1, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant